Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_metadata_facts: unit-test coverage #1196

Merged
merged 1 commit into from
Oct 26, 2022
Merged

ec2_metadata_facts: unit-test coverage #1196

merged 1 commit into from
Oct 26, 2022

Conversation

goneri
Copy link
Member

@goneri goneri commented Oct 25, 2022

Partial unit-test coverage of the ec2_metadata_facts module.

@goneri
ec2_metadata_facts: unit-test coverage
a14f7fc 
Partial unit-test coverage of the `ec2_metadata_facts` module.
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_plugin New plugin tests tests labels Oct 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 12s
✔️ build-ansible-collection SUCCESS in 6m 12s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 29s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 49s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 15s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 51s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 06s
✔️ cloud-tox-py3 SUCCESS in 3m 15s

@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Oct 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 6m 27s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 17s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 47s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 18s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 02s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 02s
✔️ cloud-tox-py3 SUCCESS in 3m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8dfe6cc into ansible-collections:main Oct 26, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

markuman pushed a commit to markuman/amazon.aws that referenced this pull request Nov 14, 2022
@jatorcasso @goneri
fix sporadic test failure in processor features (ansible-collections#…
6fa3ea2 
…1196)

rds_instance - fix sporadic test failure in processor features

SUMMARY
Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
when processor features are applied and not pending:
2022-06-01 22:24:33.960215 | controller |     "pending_modified_values": {},
2022-06-01 22:24:33.960221 | controller |     "performance_insights_enabled": false,
2022-06-01 22:24:33.960227 | controller |     "preferred_backup_window": "06:49-07:19",
2022-06-01 22:24:33.960234 | controller |     "preferred_maintenance_window": "thu:06:19-thu:06:49",
2022-06-01 22:24:33.960239 | controller |     "processor_features": {
2022-06-01 22:24:33.960245 | controller |         "coreCount": "4",
2022-06-01 22:24:33.960252 | controller |         "threadsPerCore": "2"
2022-06-01 22:24:33.960258 | controller |     },

2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] ***************************************************
2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105
2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => {
2022-06-01 22:24:45.613339 | controller |     "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'"
2022-06-01 22:24:45.613347 | controller | }

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@72be46e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@jatorcasso
fix sporadic test failure in processor features (ansible-collections#…
72be46e 
…1196)

rds_instance - fix sporadic test failure in processor features

SUMMARY
Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
when processor features are applied and not pending:
2022-06-01 22:24:33.960215 | controller |     "pending_modified_values": {},
2022-06-01 22:24:33.960221 | controller |     "performance_insights_enabled": false,
2022-06-01 22:24:33.960227 | controller |     "preferred_backup_window": "06:49-07:19",
2022-06-01 22:24:33.960234 | controller |     "preferred_maintenance_window": "thu:06:19-thu:06:49",
2022-06-01 22:24:33.960239 | controller |     "processor_features": {
2022-06-01 22:24:33.960245 | controller |         "coreCount": "4",
2022-06-01 22:24:33.960252 | controller |         "threadsPerCore": "2"
2022-06-01 22:24:33.960258 | controller |     },

2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] ***************************************************
2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105
2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => {
2022-06-01 22:24:45.613339 | controller |     "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'"
2022-06-01 22:24:45.613347 | controller | }

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory) module module needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_plugin New plugin tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goneri @ansibullbot @gravesm