Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .gitignore for inventory automatically created by integration tests #1276

Conversation

mdavis-xyz
Copy link
Contributor

SUMMARY

Helps fix #924

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests

ADDITIONAL INFORMATION

When running integration tests, a file is generated at tests/integration/inventory. This file contains paths specific to the test machine. I assume this shouldn't be committed. So I've added a .gitignore for it.

The leading slash is to make it not apply recursively. (Stack Overflow)

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage new_contributor Help guide this first time contributor tests tests labels Nov 18, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 27s
✔️ build-ansible-collection SUCCESS in 5m 48s
ansible-test-sanity-aws-ansible-python38 FAILURE in 9m 49s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 02s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 10s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 06s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 12s
✔️ cloud-tox-py3 SUCCESS in 3m 19s
ansible-test-changelog FAILURE in 2m 11s
✔️ ansible-test-splitter SUCCESS in 3m 05s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble
Copy link
Contributor

tremble commented Nov 18, 2022

Hi @mdavis-xyz thanks for this,

please could you add a "trivial" changelog entry for this.

changelogs/fragments/1276-gitignore.yml

trivial:
- gitignore - ignore integration test 'inventory' files (https://github.com/ansible-collections/amazon.aws/pull/1276)

@mdavis-xyz
Copy link
Contributor Author

Is the changelog file supposed to be named with the issue number, or PR number?

Your comment and these docs say I should use the PR number. But if I'm supposed to commit the changelog fragment before raising the PR, I don't know the PR number.
Does it not matter either way?

@mdavis-xyz
Copy link
Contributor Author

Changelog added

@tremble
Copy link
Contributor

tremble commented Nov 18, 2022

Is the changelog file supposed to be named with the issue number, or PR number?

Your comment and these docs say I should use the PR number. But if I'm supposed to commit the changelog fragment before raising the PR, I don't know the PR number. Does it not matter either way?

The name doesn't matter too much, you'll see some are using dates. What's important is that they can remain unique. PR/Issue number helps to keep things unique.

If you have an issue, then the issue should be included in the changelog entry (for example lambda_execute - Fix waiter error when ''function_arn'' is passed instead of ''name'' (https://github.com/ansible-collections/amazon.aws/issues/1268). For features rather than bugs, we generally include the PR#, unfortunately this isn't easily predicated in advance, but if the PR's otherwise good and just missing the link this can be added by the same folks who have the access to trigger the final approval/merge procedure.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Nov 18, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-splitter SUCCESS in 2m 29s
⚠️ integration-amazon.aws-1 SKIPPED
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit dbabf93 into ansible-collections:main Nov 18, 2022
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 13, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d38a4b1
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 13, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d38a4b1
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage new_contributor Help guide this first time contributor tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to run integration tests more clearly
3 participants