-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .gitignore for inventory automatically created by integration tests #1276
add .gitignore for inventory automatically created by integration tests #1276
Conversation
Hi @mdavis-xyz thanks for this, please could you add a "trivial" changelog entry for this. changelogs/fragments/1276-gitignore.yml
|
Is the changelog file supposed to be named with the issue number, or PR number? Your comment and these docs say I should use the PR number. But if I'm supposed to commit the changelog fragment before raising the PR, I don't know the PR number. |
Changelog added |
The name doesn't matter too much, you'll see some are using dates. What's important is that they can remain unique. PR/Issue number helps to keep things unique. If you have an issue, then the issue should be included in the changelog entry (for example |
…1276) Complete iam_cert and rds_snapshot deprecations SUMMARY Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate rds_instance_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
…1276) Complete iam_cert and rds_snapshot deprecations SUMMARY Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate rds_instance_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
…1276) Complete iam_cert and rds_snapshot deprecations SUMMARY Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate rds_instance_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d38a4b1
…1276) Complete iam_cert and rds_snapshot deprecations SUMMARY Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate rds_instance_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d38a4b1
…1276) Complete iam_cert and rds_snapshot deprecations SUMMARY Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases ISSUE TYPE Feature Pull Request COMPONENT NAME iam_server_certificate rds_instance_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
SUMMARY
Helps fix #924
ISSUE TYPE
COMPONENT NAME
tests
ADDITIONAL INFORMATION
When running integration tests, a file is generated at
tests/integration/inventory
. This file contains paths specific to the test machine. I assume this shouldn't be committed. So I've added a .gitignore for it.The leading slash is to make it not apply recursively. (Stack Overflow)