-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0.0] ec2_instance - Drop default value for instance_type #1315
Merged
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:main
from
tremble:deprecation/remove/6.0.0/ec2_instance
Jan 5, 2023
Merged
[6.0.0] ec2_instance - Drop default value for instance_type #1315
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:main
from
tremble:deprecation/remove/6.0.0/ec2_instance
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
label
Jan 4, 2023
tremble
force-pushed
the
deprecation/remove/6.0.0/ec2_instance
branch
from
January 4, 2023 08:54
3b346f8
to
531787c
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module
module
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
Jan 4, 2023
tremble
force-pushed
the
deprecation/remove/6.0.0/ec2_instance
branch
from
January 5, 2023 08:04
531787c
to
ec0ebe4
Compare
tremble
changed the title
ec2_instance - Drop default value for instance_type
[6.0.0] ec2_instance - Drop default value for instance_type
Jan 5, 2023
ansibullbot
added
needs_maintainer
tests
tests
and removed
owner_pr
PR created by owner/maintainer
labels
Jan 5, 2023
alinabuzachis
approved these changes
Jan 5, 2023
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename aws_secrets SUMMARY in line with the new naming guidelines rename aws_secret to secretsmanager_secret ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_secret.py plugins/modules/secretsmanager_secret.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename aws_secrets SUMMARY in line with the new naming guidelines rename aws_secret to secretsmanager_secret ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_secret.py plugins/modules/secretsmanager_secret.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Rename aws_secrets SUMMARY in line with the new naming guidelines rename aws_secret to secretsmanager_secret ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_secret.py plugins/modules/secretsmanager_secret.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
feature
This issue/PR relates to a feature request
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_maintainer
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Deprecation period was set to end 2023-01-01. This has now passed.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION