New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and move tasks (vs playbooks) in inventory tests #1394

Merged

softwarefactory-project-zuul merged 2 commits into ansible-collections:main from tremble:ansible-lint/20230301

Mar 1, 2023

Contributor

tremble commented Mar 1, 2023 •

edited

Loading

SUMMARY

Inventory plugin tests currently mix "tasks" content in with playbooks, this triggers ansible-lint warnings.

ISSUE TYPE

Tests Pull Request

COMPONENT NAME

ec2_vpc_net
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py

ADDITIONAL INFORMATION

Spotted by work on #1393


          Cleanup and move tasks (vs playbooks) in inventory tests

6ce6750

tremble requested review from GomathiselviS and alinabuzachis

March 1, 2023 08:52

Contributor

softwarefactory-project-zuul bot commented Mar 1, 2023

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/18ab2d8c97bd44fb809804e06cea5595

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 31s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 59s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 12m 06s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 15m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 50s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 11m 35s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 38s
✔️ cloud-tox-py3 SUCCESS in 9m 09s
❌ ansible-test-changelog FAILURE in 4m 11s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 13m 29s
✔️ integration-amazon.aws-2 SUCCESS in 8m 04s
Skipped 42 jobs


          unused import

493aee2

Contributor

softwarefactory-project-zuul bot commented Mar 1, 2023

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7fd28386e31541a989717b6782983f13

✔️ ansible-galaxy-importer SUCCESS in 9m 24s
✔️ build-ansible-collection SUCCESS in 12m 37s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 34s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 35s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 26s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 17s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 13s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 10m 07s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 15s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 43s
✔️ cloud-tox-py3 SUCCESS in 8m 35s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 12m 45s
✔️ integration-amazon.aws-2 SUCCESS in 8m 35s
✔️ integration-amazon.aws-3 SUCCESS in 7m 57s
Skipped 41 jobs

tremble marked this pull request as ready for review

March 1, 2023 10:08

alinabuzachis approved these changes

View reviewed changes

tremble added the mergeit label

Contributor

softwarefactory-project-zuul bot commented Mar 1, 2023

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3d30b72e317246f881e99e610a929921

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 12m 31s
✔️ ansible-test-splitter SUCCESS in 4m 44s
✔️ integration-amazon.aws-1 SUCCESS in 15m 18s
✔️ integration-amazon.aws-2 SUCCESS in 12m 52s
✔️ integration-amazon.aws-3 SUCCESS in 9m 59s
Skipped 41 jobs

softwarefactory-project-zuul bot merged commit bd8dd88 into ansible-collections:main

tremble deleted the ansible-lint/20230301 branch

September 27, 2023 06:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit