Deprecate ignored boto3 parameters #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
Apr 11, 2024
…ws_region() and get_aws_connection_info()
tremble
added
mergeit
|
regate |
|
regate |
|
regate |
|
regate |
|
regate |
|
regate |
softwarefactory-project-zuul
bot
merged commit cd455f0
into
ansible-collections:main
40 of 41 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2055 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
Deprecate ignored boto3 parameters SUMMARY module_utils.botocore.get_aws_region(), module_utils.botocore.get_aws_connection_info() and module_utils.ec2.get_ec2_security_group_ids_from_names() currently have boto3 parameters which default to None, and do nothing. This is a leftover from dropping support for the old boto SDK back in release 4.0.0. Start the cleanup process and deprecate the parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/ec2.py plugins/module_utils/elbv2.py plugins/module_utils/modules.py plugins/modules/ec2_eni.py ADDITIONAL INFORMATION (see also ansible-collections/community.aws#2075) Reviewed-by: Alina Buzachis (cherry picked from commit cd455f0)
tremble
added a commit
that referenced
this pull request
Apr 18, 2024
Deprecate ignored boto3 parameters SUMMARY module_utils.botocore.get_aws_region(), module_utils.botocore.get_aws_connection_info() and module_utils.ec2.get_ec2_security_group_ids_from_names() currently have boto3 parameters which default to None, and do nothing. This is a leftover from dropping support for the old boto SDK back in release 4.0.0. Start the cleanup process and deprecate the parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/ec2.py plugins/module_utils/elbv2.py plugins/module_utils/modules.py plugins/modules/ec2_eni.py ADDITIONAL INFORMATION (see also ansible-collections/community.aws#2075) Reviewed-by: Alina Buzachis (cherry picked from commit cd455f0)
tremble
added a commit
that referenced
this pull request
Apr 18, 2024
Deprecate ignored boto3 parameters SUMMARY module_utils.botocore.get_aws_region(), module_utils.botocore.get_aws_connection_info() and module_utils.ec2.get_ec2_security_group_ids_from_names() currently have boto3 parameters which default to None, and do nothing. This is a leftover from dropping support for the old boto SDK back in release 4.0.0. Start the cleanup process and deprecate the parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/ec2.py plugins/module_utils/elbv2.py plugins/module_utils/modules.py plugins/modules/ec2_eni.py ADDITIONAL INFORMATION (see also ansible-collections/community.aws#2075) Reviewed-by: Alina Buzachis (cherry picked from commit cd455f0) Co-authored-by: Mark Chappell <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
SUMMARY Since we dropped support for the old boto SDK (#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated #2047) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
SUMMARY Since we dropped support for the old boto SDK (ansible-collections#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated ansible-collections#2047) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
SUMMARY Since we dropped support for the old boto SDK (ansible-collections#630) the boto3 parameter for get_aws_region() and get_aws_connection_info() has done nothing. This finally removes the parameter (deprecated ansible-collections#2047) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
module_utils.botocore.get_aws_region(),module_utils.botocore.get_aws_connection_info()andmodule_utils.ec2.get_ec2_security_group_ids_from_names()currently haveboto3parameters which default to None, and do nothing. This is a leftover from dropping support for the old boto SDK back in release 4.0.0.Start the cleanup process and deprecate the parameter.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/ec2.py
plugins/module_utils/elbv2.py
plugins/module_utils/modules.py
plugins/modules/ec2_eni.py
ADDITIONAL INFORMATION
(see also ansible-collections/community.aws#2075)