Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create initial test suite for ec2_metadata_facts #212

Merged
merged 6 commits into from
Dec 4, 2020

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Dec 1, 2020

SUMMARY

Create an instance, run metadata on the remote instance, and teardown.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests/integration/targets/ec2_metadata_facts/

Create an instance, run metadata on the remote instance, and teardown.
@jillr jillr force-pushed the ec2_metadata_facts_tests branch from 7d6b8a5 to dcaa7b5 Compare December 1, 2020 23:24
@jillr
Copy link
Collaborator Author

jillr commented Dec 1, 2020

@tremble This actually ended up being less hacky than I thought it would. Thoughts?

@jillr
Copy link
Collaborator Author

jillr commented Dec 1, 2020

Hrm. TODO: handle running teardown.yml even if test_initial_metadata.yml fails, ssh works on my machine but not shippable?

jillr added 2 commits December 2, 2020 17:14
Add a wait_for_connection to test playbook
Some minor cleanup
@jillr jillr force-pushed the ec2_metadata_facts_tests branch 5 times, most recently from 42329d9 to 5ae14c5 Compare December 3, 2020 21:25
@jillr jillr force-pushed the ec2_metadata_facts_tests branch from 5ae14c5 to dcd93b2 Compare December 3, 2020 23:15
@jillr jillr requested a review from tremble December 4, 2020 17:39
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble merged commit 8917a74 into ansible-collections:main Dec 4, 2020
@jillr jillr deleted the ec2_metadata_facts_tests branch July 2, 2021 22:48
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants