-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initial test suite for ec2_metadata_facts #212
Merged
tremble
merged 6 commits into
ansible-collections:main
from
jillr:ec2_metadata_facts_tests
Dec 4, 2020
Merged
Create initial test suite for ec2_metadata_facts #212
tremble
merged 6 commits into
ansible-collections:main
from
jillr:ec2_metadata_facts_tests
Dec 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an instance, run metadata on the remote instance, and teardown.
jillr
force-pushed
the
ec2_metadata_facts_tests
branch
from
December 1, 2020 23:24
7d6b8a5
to
dcaa7b5
Compare
@tremble This actually ended up being less hacky than I thought it would. Thoughts? |
Hrm. TODO: handle running teardown.yml even if test_initial_metadata.yml fails, ssh works on my machine but not shippable? |
tremble
requested changes
Dec 2, 2020
tests/integration/targets/ec2_metadata_facts/playbooks/test_initial_metadata.yml
Outdated
Show resolved
Hide resolved
Add a wait_for_connection to test playbook Some minor cleanup
general cleanup
jillr
force-pushed
the
ec2_metadata_facts_tests
branch
5 times, most recently
from
December 3, 2020 21:25
42329d9
to
5ae14c5
Compare
jillr
force-pushed
the
ec2_metadata_facts_tests
branch
from
December 3, 2020 23:15
5ae14c5
to
dcd93b2
Compare
tremble
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ated not the default VPC (ansible-collections#212)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Create an instance, run metadata on the remote instance, and teardown.
ISSUE TYPE
COMPONENT NAME
tests/integration/targets/ec2_metadata_facts/