Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #347 backport][stable-1.5] remove references to shippable from repo #777

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 20, 2022

This is a partial backport of PR #347 as merged into main (bcba669).

SUMMARY

This collection has been operating on Zuul CI for some weeks now

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

shippable.yml
tests/
README.md

@tremble tremble changed the base branch from main to stable-1.5 April 20, 2022 07:46
@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration needs_triage plugins plugin (any type) tests tests labels Apr 20, 2022
@tremble tremble force-pushed the backport/stable-1.5/pull-347 branch from 9a4c5b6 to 526e02f Compare April 20, 2022 07:47
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble force-pushed the backport/stable-1.5/pull-347 branch from 526e02f to 01dda32 Compare April 20, 2022 08:57
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 20, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble tremble force-pushed the backport/stable-1.5/pull-347 branch from 01dda32 to b93f02a Compare April 21, 2022 11:59
@tremble
Copy link
Contributor Author

tremble commented Apr 21, 2022

I've removed some of the flaky tests so we can push this through piecemeal

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 21, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 25, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@tremble tremble requested a review from alinabuzachis April 25, 2022 11:25
@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 714482d into ansible-collections:stable-1.5 Apr 26, 2022
@tremble tremble deleted the backport/stable-1.5/pull-347 branch September 9, 2022 08:51
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@07e2522
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@07e2522
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@07e2522
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@07e2522
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@07e2522
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
lambda_info - use a paginator and AWSRetry

SUMMARY
Add paginator and AWSRetry to lambda_info.  It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants