-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: split up ec2_instance #979
tests: split up ec2_instance #979
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
199830d
to
2cb7bd4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2cb7bd4
to
bb232f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ff2d5e2
to
5d2469c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5d2469c
to
8e0a3aa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b9f3acf
to
d6b179e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
d6b179e
to
36f887a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
36f887a
to
67c1bcc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
67c1bcc
to
381c8a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the tests don't require a new version of botocore/boto3, please prune the use of setup_botocore_pip as this adds a couple of minutes to each test.
Most of the tests don't use the iam roles, I'd avoid coyping first_iam_role
, second_iam_role
and unique_id
around.
Looking at ec2_instance_find_ami
, I think this should be removed (and should have been removed a while back): Everything's using ec2_ami_id
which comes from setup_ec2_facts
.
resource_prefix is consistent for a single ansible-test run, this is going to result in identical VPCs being created and (in theory) deleted, please update vpc_name and vpc_seed to be unique per-test. This helps identify which test is misbehaving when things go wrong and avoid weird edge cases when things go wrong and retries happen.
The new modules aren't deleting the VPCs and subnets they create. We're only not hitting limits because they're reusing the same VPCs and subnets over and over, this is also going to cause weird failures when aws-terminator happens to clean up at the wrong time. While the window is small, it's still there and a PITA to debug. It might be possible to do something clever, using a handler to trigger the cleanup as we do with setup_botocore_pip. While you're at it I'd probably use the "search based on VPC" trick that we're using for EC2s and ENIs when cleaning up Security Groups and Subnets.
I also have a vague memory that ansible-test won't automatically trigger all of these tests if someone runs this 'locally', but I'll test this...
|
2332f75
to
350e6ae
Compare
350e6ae
to
4fee066
Compare
|
Thank you @tremble for the patch. |
Build failed (gate pipeline). For information on how to proceed, see Warning: |
regate |
…ble-collections#970) redshift_info - fix invalid import path for botocore exceptions Depends-On: ansible-collections#979 SUMMARY Fix invalid import path for botocore exceptions Fixes ansible-collections#968 ISSUE TYPE Bugfix Pull Request COMPONENT NAME redshift_info Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
…ble-collections#970) redshift_info - fix invalid import path for botocore exceptions Depends-On: ansible-collections#979 SUMMARY Fix invalid import path for botocore exceptions Fixes ansible-collections#968 ISSUE TYPE Bugfix Pull Request COMPONENT NAME redshift_info Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
CI: redshift_info is an alias of redshift Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]>
…ble-collections#970) redshift_info - fix invalid import path for botocore exceptions Depends-On: ansible-collections#979 SUMMARY Fix invalid import path for botocore exceptions Fixes ansible-collections#968 ISSUE TYPE Bugfix Pull Request COMPONENT NAME redshift_info Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Alina Buzachis <None>
Use on target per sub-test to have a better control on the global execution
time and simplify the troubleshooting.