Fix rolling restart on Linux

[42esoulard]

SUMMARY

Fixes the rolling restart on Linux in which the the consul service restart was happening too soon after the consul leave, which resulted in the playbook proceeding without the new election finalizing and a temporarily leaderless cluster.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• Rolling restart consul on Unix

ADDITIONAL INFORMATION

• Since we are using a new variable consul_pid_file, it was replaced in all occurrences in the templates as well.

[bbaassssiiee]

Thanks for your contribution! This repo is looking for maintainers...

If feasible, please rebase this PR on master to drop that merge commit. That way we have a linear commit history.

[bbaassssiiee]

Please take a look at the output of the checks that ran and amend your PR.

[bbaassssiiee]

There is still one linting issue:

yaml[indentation]: Wrong indentation: expected 4 but found 2
tasks/leave_restart_consul.yml:12
Error: Wrong indentation: expected 4 but found 2

WARNING  The following filters were mocked during the run: json_query
Read documentation for instructions on how to ignore specific rule violations.

                Rule Violation Summary                
 count tag               profile rule associated tags 
     1 yaml[indentation] basic   formatting, yaml     

[bbaassssiiee]

Would you have time to also remove the directory ./molecule/centos-stream-8?
Centos 8 Stream End-of-life happened to happen 4 days ago (31 May 2024) https://endoflife.date/centos-stream

[bbaassssiiee]

Great work!