-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ios_command regex failure and ios_user shell timeout issue #82
Merged
ansible-zuul
merged 8 commits into
ansible-collections:master
from
ganeshrn:fix_regex_issue
Jun 19, 2020
Merged
Fix ios_command regex failure and ios_user shell timeout issue #82
ansible-zuul
merged 8 commits into
ansible-collections:master
from
ganeshrn:fix_regex_issue
Jun 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increase logging buffer size on device before issuing logs that matches error regex
justjais
approved these changes
Jun 17, 2020
ganeshrn
force-pushed
the
fix_regex_issue
branch
from
June 17, 2020 11:18
54d2d5c
to
3c6d356
Compare
recheck |
2 similar comments
recheck |
recheck |
justjais
changed the title
Fix ios_command regex failure issue
Fix ios_command regex failure and ios_user shell timeout issue
Jun 18, 2020
recheck |
pabelanger
reviewed
Jun 18, 2020
ignore_errors: true | ||
register: results | ||
vars: | ||
ansible_user: ssh_user | ||
ansible_private_key_file: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 92 below, we first need to reset_connection now, as we are no longer using the zuul user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Merged
This was referenced Jun 18, 2020
ganeshrn
force-pushed
the
fix_regex_issue
branch
from
June 18, 2020 13:58
0244304
to
0fe77c4
Compare
* Remove local connection test as plugin options not supported with local connection type and connection=local is depcrecated
ganeshrn
force-pushed
the
fix_regex_issue
branch
from
June 18, 2020 13:58
0fe77c4
to
154c41c
Compare
This was referenced Jun 18, 2020
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jul 29, 2020
v2.9.11 ======= Minor Changes ------------- - The ``items2dict`` filter can now create a dict whose values are the original elements of the input list, and whose keys are the value of some key in each dict. When the resulting dict is stored, this allows for O(1) lookup of a particular key without having to scan the entire list each time. - k8s - update openshift requirements in documentation - pipe lookup - update docs for Popen with shell=True usages (ansible/ansible#70159). Bugfixes -------- - Allow TypeErrors on Undefined variables in filters to be handled or deferred when processing for loops. - Fix ``delegate_facts: true`` when ``ansible_python_interpreter`` is not set. (ansible/ansible#70168) - Support check mode in NXOS BGP modules (ansible/ansible#57360). - TaskExecutor - Handle unexpected errors as failed while post validating loops (ansible/ansible#70050). - The `ansible_become` value was not being treated as a boolean value when set in an INI format inventory file (fixes bug ansible/ansible#70476). - To fix ios_l2_interfaces facts parsing issue (ansible-collections/cisco.ios#59) - To fix ios_user and ios_command test case failure fix (ansible-collections/cisco.ios#82) - Vault - Allow single vault encrypted values to be used directly as module parameters. (ansible/ansible#68275) - add constraints file for ``anisble_runner`` test since an update to ``psutil`` is now causing test failures - ansible-galaxy - Instead of assuming the first defined server is galaxy, filter based on the servers that support the v1 API, and return the first of those (ansible/ansible#65440) - ansible-test no longer tracebacks during change analysis due to processing an empty python file - ansible-test now correctly recognizes imports in collections when using the ``--changed`` option. - ansible-test now ignores empty ``*.py`` files when analyzing module_utils imports for change detection - assemble - fix decrypt argument in the module (ansible/ansible#65450). - docker_container - various error fixes in string handling for Python 2 to avoid crashes when non-ASCII characters are used in strings (ansible-collections/community.general#640). - eos_eapi - enable eapi by default - group_by now should correctly refect changed status. - json callback - Fix host result to task references in the resultant JSON output for non-lockstep strategy plugins such as free (ansible/ansible#65931) - nmcli - Add compatibility for new networkmanager library (ansible/ansible#65726). - puppet - fix command line construction for check mode and ``manifest:`` (ansible/ansible#60576). - selective callback - mark task failed correctly (ansible/ansible#63767). - windows async - use full path when calling PowerShell to reduce reliance on environment vars being correct - ansible/ansible#70655 - winrm - preserve winrm forensic data on put_file failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
before issuing logs that matches error regex
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION