Wrong datatype in ecs_taskdefinition.containers

[iljau]

community.aws/plugins/modules/ecs_taskdefinition.py

Line 324 in 6eab8b0

containers=dict(required=False, type='list', elements='str'),

In current version argument_spec is following:
containers=dict(required=False, type='list', elements='str'),

This causes dicts inside container list to be converted to strings.

If we select some example from documentation ...

- name: Create task definition
  community.aws.ecs_taskdefinition:
    family: nginx
    containers:
    - name: nginx
      essential: true
      image: "nginx"
      portMappings:
      - containerPort: 8080
        hostPort:      8080
      cpu: 512
      memory: 1024
    state: present

... then running it causes following exception:

  File "[..]/debug_dir/ansible_collections/community/aws/plugins/modules/ecs_taskdefinition.py", line 353, in main
    for environment in container.get('environment', []):
AttributeError: 'str' object has no attribute 'get'

To get examples (and container section) working, argument spec needs to be changed to following:
containers=dict(required=False, type='list', elements='dict'),

[emuuli]

Yes, it seems to be an issue indeed.
The last time I used it was not in the community edition, but the built-in ecs_taskdefinition.py, in which it worked:
https://github.com/ansible/ansible/blob/stable-2.4/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

As you can see from there the elements were not forced to be converted into any data format. Now the formatting is forced and it seems that they shouldn't be forced to be strings, but rather dicts if any as the reporter suggested.

Is there anything that we're missing here?

[markuman]

#251

[markuman]

ansible-collections/amazon.aws#184

[markuman]

Ah no...
the fix is easy...and not related by what I've linked.
element=str is just wrong.