Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_instance does not remove VPC security groups until you add another one #385

Closed
pauby opened this issue Feb 2, 2021 · 1 comment · Fixed by #500
Closed

rds_instance does not remove VPC security groups until you add another one #385

pauby opened this issue Feb 2, 2021 · 1 comment · Fixed by #500
Assignees
Labels
bug This issue/PR relates to a bug python3

Comments

@pauby
Copy link

pauby commented Feb 2, 2021

SUMMARY

When using community.aws.rds_instance you can add security group ids using the vpc_security_group_ids parameter and this is reflected in the VPC security groups on the RDS instance. However if you remove a group the VPC security groups on the RDS instance is not updated. If you add a group after this, the old group is removed and the new group is added.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

community.aws.rds_instance

ANSIBLE VERSION
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.7.7 (default, Mar 13 2020, 21:39:43) [GCC 9.2.1 20190827 (Red Hat 9.2.1-1)]
CONFIGURATION
INTERPRETER_PYTHON(/etc/ansible/ansible.cfg) = auto
OS / ENVIRONMENT

AWS RDS instance

STEPS TO REPRODUCE

If I remove "sg_1" nothing is updated on the DB instance. If I add "sg_4" so you have "sg_2", "sg_3" and "sg_4", then "sg_1" is then removed and "sg_4" is added.

    - name: "Ensure RDS instance"
      community.aws.rds_instance:
        db_instance_identifier: 'db_name'
        apply_immediately: yes
        purge_tags: yes
        copy_tags_to_snapshot: yes
        tags:
          Name: 'db_name'
          managed_by: 'ansible'
        vpc_security_group_ids:
          - "sg_1"
          - 'sg-2'
          - 'sg-3''
        db_subnet_group_name: 'default-vpc-abc'
        wait: no
EXPECTED RESULTS

I expect "sg_1" to be removed when I remove it from the list.

ACTUAL RESULTS

Nothing happens to "sg_1" until I add "sg_4" to the list.


@pauby pauby changed the title rds_instance does not remove vpc security groups until you add one rds_instance does not remove VPC security groups until you add another one Feb 2, 2021
@ansibullbot
Copy link

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug needs_triage python3 labels Feb 2, 2021
@alinabuzachis alinabuzachis self-assigned this Mar 17, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Mar 25, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Mar 25, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Mar 25, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Mar 25, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Mar 25, 2021
tremble pushed a commit that referenced this issue Apr 7, 2021
* rds_instance: Add purge_security_groups feature for vpc_security_groups_ids.
	* Fixes: #385
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
* rds_instance: Add purge_security_groups feature for vpc_security_groups_ids.
	* Fixes: ansible-collections#385
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
* rds_instance: Add purge_security_groups feature for vpc_security_groups_ids.
	* Fixes: ansible-collections#385
danielcotton pushed a commit to danielcotton/community.aws that referenced this issue Nov 23, 2021
* rds_instance: Add purge_security_groups feature for vpc_security_groups_ids.
	* Fixes: ansible-collections#385
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
…llections#387)

s3_bucket - improve documentation of policy parameter

SUMMARY
This pull requests improves the documentation of the policy parameter in the s3_bucket module. It documents how to ensure the absence of a policy.
Fixes ansible-collections#385
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
s3_bucket

Reviewed-by: Jill R <None>
Reviewed-by: Moritz Wagner <None>
Reviewed-by: None <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
* rds_instance: Add purge_security_groups feature for vpc_security_groups_ids.
	* Fixes: ansible-collections#385

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@cd32e65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug python3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants