Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_launch_template: Allow tags for just instance or volume #48

Closed
leedm777 opened this issue Apr 23, 2020 · 3 comments
Closed

ec2_launch_template: Allow tags for just instance or volume #48

leedm777 opened this issue Apr 23, 2020 · 3 comments
Labels
affects_2.10 feature This issue/PR relates to a feature request good first issue module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@leedm777
Copy link
Contributor

SUMMARY

The current tags option will set the tags on both the instances and volumes created by the launch template. The interferes with use by EC2 Fleet, and generally it would be better if we could specify tags for instances and volumes independently.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ec2_launch_template

ADDITIONAL INFORMATION

Launch templates that tag volumes, unfortunately, does not work with EC2 Fleet. The policy for the AWSServiceRoleForEC2Fleet service role does not have permission to create tags on volumes (and both the policy and role are not editable, so the permission cannot be granted). The net effect is that if you use Ansible to create the launch template, and you use tags, then you can't use that launch template with EC2 Fleet.

I'm thinking that new instance_tags and volume_tags could be added to tag instances and volumes independently.

- name: Create an ec2 launch template with tags on instances and volumes
  ec2_launch_template:
    name: "my_template"
    image_id: "ami-04b762b4289fba92b"
    key_name: my_ssh_key
    instance_type: t2.micro
    iam_instance_profile: myTestProfile
    instance_tags:
      Name: some_instance
    volume_tags:
      Purpose: some_storage
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request module module needs_triage labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 28, 2020
@gravesm gravesm added waiting_on_contributor Needs help. Feel free to engage to get things unblocked and removed needs_triage labels Jan 29, 2021
@markuman
Copy link
Member

A new parameter tags_resource_type must be introduced.

https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/ec2_launch_template.py#L456-L459

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@Akasurde
Include FQCN in module examples (ansible-collections#48)
72298ca 
Signed-off-by: Abhijeet Kasurde <[email protected]>
@abikouo abikouo mentioned this issue Oct 7, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 18, 2024
@abikouo
Prepare module ec2_launch_template for promotion (#2164)
40d61f0 
SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes #176)
Add the possibility to tag specific resources, not always instance and volume (Closes [#48](#48, Closes #2083)
Support EBS Throughput (Closes #1944)
Fix issue occurring when launch template contains more than 200 versions (Closes #2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
@abikouo abikouo closed this as completed Oct 18, 2024
alinabuzachis pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2024
@abikouo @alinabuzachis
Prepare module ec2_launch_template for promotion (ansible-collections…
974991b 
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this issue Oct 25, 2024
@abikouo @alinabuzachis
Prepare module ec2_launch_template for promotion (ansible-collections…
d5a0a10 
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects_2.10 feature This issue/PR relates to a feature request good first issue module module plugins plugin (any type) waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leedm777 @gravesm @markuman @ansibullbot @abikouo