Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1092/2ea42db3 backport][stable-2] Fixing parameter name in example. #1094

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 26, 2022

This is a backport of PR #1092 as merged into main (2ea42db).

SUMMARY

Fixing parameter used in example.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_acm

ADDITIONAL INFORMATION

Using the example as is gives in an error -

fatal: [localhost]: FAILED! => changed=false 
  msg: 'state is present but all of the following are missing: private_key'

Fixing parameter name in example.

SUMMARY
Fixing parameter used in example.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -
fatal: [localhost]: FAILED! => changed=false
  msg: 'state is present but all of the following are missing: private_key'

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 2ea42db)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Apr 26, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c7ca159 into stable-2 Apr 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092 branch April 26, 2022 12:39
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1086)" (ansible-collections#1094)

Revert "Work around for ansible-collections#1083 (ansible-collections#1086)"

This reverts commit e0aeafd.
SUMMARY
Following ansible-collections#1087 we no longer need the workaround for ansible-collections#1083.
The work around has been backported to stable-4, which still announces support for Ansible 2.9, however we've now dropped support for 2.9 so don't need this in main/5.0.0
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/cloud.py
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants