-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1092/2ea42db3 backport][stable-2] Fixing parameter name in example. #1094
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-2
from
patchback/backports/stable-2/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092
Apr 26, 2022
Merged
[PR #1092/2ea42db3 backport][stable-2] Fixing parameter name in example. #1094
softwarefactory-project-zuul
merged 1 commit into
stable-2
from
patchback/backports/stable-2/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing parameter name in example. SUMMARY Fixing parameter used in example. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_acm ADDITIONAL INFORMATION Using the example as is gives in an error - fatal: [localhost]: FAILED! => changed=false msg: 'state is present but all of the following are missing: private_key' Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Mark Chappell <None> (cherry picked from commit 2ea42db)
ansibullbot
added
community_review
docs
module
module
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
small_patch
Hopefully easy to review
labels
Apr 26, 2022
markuman
approved these changes
Apr 26, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-2/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092
branch
April 26, 2022 12:39
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1086)" (ansible-collections#1094) Revert "Work around for ansible-collections#1083 (ansible-collections#1086)" This reverts commit e0aeafd. SUMMARY Following ansible-collections#1087 we no longer need the workaround for ansible-collections#1083. The work around has been backported to stable-4, which still announces support for Ansible 2.9, however we've now dropped support for 2.9 so don't need this in main/5.0.0 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/cloud.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
mergeit
Merge the PR (SoftwareFactory)
module
module
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
small_patch
Hopefully easy to review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1092 as merged into main (2ea42db).
SUMMARY
Fixing parameter used in example.
ISSUE TYPE
COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -