-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging - remove default empty dict where purge_tags default is True #1183
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/default_dict
Jun 1, 2022
Merged
Tagging - remove default empty dict where purge_tags default is True #1183
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/default_dict
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
May 30, 2022
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
tagging/default_dict
branch
from
May 30, 2022 19:41
a54f423
to
bd4fcca
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…urge_tags default is True
tremble
force-pushed
the
tagging/default_dict
branch
from
May 31, 2022 07:24
bd4fcca
to
2ea908a
Compare
alinabuzachis
approved these changes
Jun 1, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
mergeit
Merge the PR (SoftwareFactory)
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/amazon.aws#844
SUMMARY
{}
and useNone
instead, so that purging tags only happens if someone explicitly passes the tags parameterISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_transit_gateway.py
plugins/modules/efs.py
plugins/modules/eks_fargate_profile.py
plugins/modules/elb_target_group.py
ADDITIONAL INFORMATION