rds_instance - fix sporadic test failure in processor features #1196

jatorcasso · 2022-06-02T02:25:05Z

SUMMARY

Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

rds_instance

ADDITIONAL INFORMATION

when processor features are applied and not pending:

2022-06-01 22:24:33.960215 | controller |     "pending_modified_values": {},
2022-06-01 22:24:33.960221 | controller |     "performance_insights_enabled": false,
2022-06-01 22:24:33.960227 | controller |     "preferred_backup_window": "06:49-07:19",
2022-06-01 22:24:33.960234 | controller |     "preferred_maintenance_window": "thu:06:19-thu:06:49",
2022-06-01 22:24:33.960239 | controller |     "processor_features": {
2022-06-01 22:24:33.960245 | controller |         "coreCount": "4",
2022-06-01 22:24:33.960252 | controller |         "threadsPerCore": "2"
2022-06-01 22:24:33.960258 | controller |     },

2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] ***************************************************
2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105
2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => {
2022-06-01 22:24:45.613339 | controller |     "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'"
2022-06-01 22:24:45.613347 | controller | }

softwarefactory-project-zuul · 2022-06-02T03:18:27Z

Build succeeded.

ansibullbot · 2022-06-02T03:19:36Z

cc @jillr @markuman @s-hertel @tremble
click here for bot help

softwarefactory-project-zuul · 2022-06-03T16:28:36Z

Build succeeded (gate pipeline).

patchback · 2022-06-03T16:28:40Z

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 72be46e on top of patchback/backports/stable-3/72be46e76c88fca590f65b9df1626ef1a52a08e1/pr-1196

Backporting merged PR #1196 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/community.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-3/72be46e76c88fca590f65b9df1626ef1a52a08e1/pr-1196 upstream/stable-3

Now, cherry-pick PR rds_instance - fix sporadic test failure in processor features #1196 contents into that branch:
```
$ git cherry-pick -x 72be46e76c88fca590f65b9df1626ef1a52a08e1
```
If it'll yell at you with something like fatal: Commit 72be46e76c88fca590f65b9df1626ef1a52a08e1 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x 72be46e76c88fca590f65b9df1626ef1a52a08e1
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR rds_instance - fix sporadic test failure in processor features #1196 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-3/72be46e76c88fca590f65b9df1626ef1a52a08e1/pr-1196

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

github-actions · 2022-06-03T16:33:41Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

…1196) rds_instance - fix sporadic test failure in processor features SUMMARY Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION when processor features are applied and not pending: 2022-06-01 22:24:33.960215 | controller | "pending_modified_values": {}, 2022-06-01 22:24:33.960221 | controller | "performance_insights_enabled": false, 2022-06-01 22:24:33.960227 | controller | "preferred_backup_window": "06:49-07:19", 2022-06-01 22:24:33.960234 | controller | "preferred_maintenance_window": "thu:06:19-thu:06:49", 2022-06-01 22:24:33.960239 | controller | "processor_features": { 2022-06-01 22:24:33.960245 | controller | "coreCount": "4", 2022-06-01 22:24:33.960252 | controller | "threadsPerCore": "2" 2022-06-01 22:24:33.960258 | controller | }, 2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] *************************************************** 2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105 2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => { 2022-06-01 22:24:45.613339 | controller | "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'" 2022-06-01 22:24:45.613347 | controller | } Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 72be46e)

Backport stable-3: rds_instance SUMMARY Manual backports of #1081 #1196 ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME rds_instance Reviewed-by: Alina Buzachis <None>

…1196) rds_instance - fix sporadic test failure in processor features SUMMARY Seen a few failures in CI testing when professor features are actually applied and not pending (in pending_modified_values) ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION when processor features are applied and not pending: 2022-06-01 22:24:33.960215 | controller | "pending_modified_values": {}, 2022-06-01 22:24:33.960221 | controller | "performance_insights_enabled": false, 2022-06-01 22:24:33.960227 | controller | "preferred_backup_window": "06:49-07:19", 2022-06-01 22:24:33.960234 | controller | "preferred_maintenance_window": "thu:06:19-thu:06:49", 2022-06-01 22:24:33.960239 | controller | "processor_features": { 2022-06-01 22:24:33.960245 | controller | "coreCount": "4", 2022-06-01 22:24:33.960252 | controller | "threadsPerCore": "2" 2022-06-01 22:24:33.960258 | controller | }, 2022-06-01 22:24:45.612919 | controller | TASK [rds_instance : assert] *************************************************** 2022-06-01 22:24:45.613111 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_processor.yml:105 2022-06-01 22:24:45.613324 | controller | fatal: [processor]: FAILED! => { 2022-06-01 22:24:45.613339 | controller | "msg": "The conditional check 'result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"' failed. The error was: error while evaluating conditional (result.pending_modified_values.processor_features.coreCount == \"4\" or result.processor_features.coreCount == \"4\"): 'dict object' has no attribute 'processor_features'" 2022-06-01 22:24:45.613347 | controller | } Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@72be46e

ec2_metadata_facts: unit-test coverage Partial unit-test coverage of the ec2_metadata_facts module. Reviewed-by: Mike Graves <[email protected]>

fix sporadic test failure in processor features

714d53e

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage performance plugins plugin (any type) tests tests labels Jun 2, 2022

jatorcasso requested review from alinabuzachis and markuman June 2, 2022 04:17

markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Jun 2, 2022

markuman approved these changes Jun 2, 2022

View reviewed changes

ansibullbot removed the needs_triage label Jun 2, 2022

alinabuzachis approved these changes Jun 2, 2022

View reviewed changes

jatorcasso added mergeit Merge the PR (SoftwareFactory) and removed backport-2 PR should be backported to the stable-2 branch labels Jun 3, 2022

softwarefactory-project-zuul bot merged commit 72be46e into ansible-collections:main Jun 3, 2022

jatorcasso mentioned this pull request Jun 6, 2022

Backport stable-3: rds_instance #1222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rds_instance - fix sporadic test failure in processor features #1196

rds_instance - fix sporadic test failure in processor features #1196

jatorcasso commented Jun 2, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 2, 2022

ansibullbot commented Jun 2, 2022

softwarefactory-project-zuul bot commented Jun 3, 2022

patchback bot commented Jun 3, 2022 •

edited

Loading

github-actions bot commented Jun 3, 2022

rds_instance - fix sporadic test failure in processor features #1196

rds_instance - fix sporadic test failure in processor features #1196

Conversation

jatorcasso commented Jun 2, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Jun 2, 2022

ansibullbot commented Jun 2, 2022

softwarefactory-project-zuul bot commented Jun 3, 2022

patchback bot commented Jun 3, 2022 • edited Loading

Backport to stable-3: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1196 into main

github-actions bot commented Jun 3, 2022

Docs Build 📝

jatorcasso commented Jun 2, 2022 •

edited

Loading

patchback bot commented Jun 3, 2022 •

edited

Loading