wafv2_ip_set - add support for updating tags #1205
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
|
recheck |
tremble
force-pushed
the
tagging/purge/wafv2_ip_set
branch
from
bd3fc52 to
d3e0d15
Compare
|
there should be a |
| tags=dict(type='dict'), | ||
| purge_addresses=dict(type='bool', default=True) | ||
| tags=dict(type='dict', aliases=['resource_tags']), | ||
| purge_tags=dict(type='bool', default=True), |
There was a problem hiding this comment.
| purge_tags=dict(type='bool', default=True), | |
| purge_tags=dict(type='bool', default=False), |
in the first release
I was in two minds over the default value. Since it didn't seem to set tags at all on update previously, I went with defaulting to True... |
Yes good question. This will hit only users that are dealing with boto3 and maybe other orchestration tools like cloudformation....but dunno. better safe than sorry? |
unless tags is explicitly set in the task |
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/wafv2.py
plugins/modules/wafv2_ip_set.py
plugins/modules/wafv2_ip_set_info.py
ADDITIONAL INFORMATION
Depends on : mattclay/aws-terminator#213