rename aws_eks_cluster -> eks_cluster #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
Jun 28, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Fix inventory test error handling SUMMARY The inventory tests were ignoring errors. Fix a broken test (aws_ec2) Ensure that when errors are thrown the test actually fails ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py ADDITIONAL INFORMATION See for example: https://ansible.softwarefactory-project.io/zuul/build/44fb0537b2a94472a8db8fe3d38e5f2e - https://9579ab6a3b03fcb3c00a-69908a85d5fb5681d7c2fae55d6bef4c.ssl.cf2.rackcdn.com/1218/0488965660f26bad143f612c7290f0a6ecdffcf7/gate/integration-amazon.aws-1/44fb053/job-output.txt Tests "passed", but there were failures being ignored 2022-11-14 12:08:36.997752 | controller | TASK [meta] ******************************************************************** 2022-11-14 12:08:36.997757 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/inventory_aws_ec2/playbooks/test_populating_inventory_with_hostvars_prefix_suffix.yml:34 2022-11-14 12:08:36.997763 | controller | setting up inventory plugins 2022-11-14 12:08:36.997768 | controller | Parsed /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/inventory_aws_ec2/test.aws_ec2.yml inventory source with ansible_collections.amazon.aws.plugins.inventory.aws_ec2 plugin 2022-11-14 12:08:36.997778 | controller | META: inventory successfully refreshed 2022-11-14 12:08:36.997784 | controller | 2022-11-14 12:08:36.997790 | controller | TASK [assert the hostvars are defined with prefix and/or suffix] *************** 2022-11-14 12:08:36.997794 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/inventory_aws_ec2/playbooks/test_populating_inventory_with_hostvars_prefix_suffix.yml:36 2022-11-14 12:08:37.221690 | controller | fatal: [127.0.0.1]: FAILED! => { 2022-11-14 12:08:37.221731 | controller | "msg": "The conditional check 'hostvars['ansible-test-76941238-ip-172-16-11-90'].aws_ec2_instance_type == 't2.micro'' failed. The error was: error while evaluating conditional (hostvars['ansible-test-76941238-ip-172-16-11-90'].aws_ec2_instance_type == 't2.micro'): \"hostvars['ansible-test-76941238-ip-172-16-11-90']\" is undefined. \"hostvars['ansible-test-76941238-ip-172-16-11-90']\" is undefined" 2022-11-14 12:08:37.221741 | controller | } 2022-11-14 12:08:37.221749 | controller | 2022-11-14 12:08:37.221756 | controller | PLAY RECAP ********************************************************************* 2022-11-14 12:08:37.221765 | controller | 127.0.0.1 : ok=11 changed=1 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0 2022-11-14 12:08:37.221772 | controller | 2022-11-14 12:08:37.221780 | controller | AWS ACTIONS: ['ec2:CreateTags', 'ec2:DeleteTags', 'ec2:DescribeImages', 'ec2:DescribeInstanceAttribute', 'ec2:DescribeInstances', 'ec2:DescribeSecurityGroups', 'ec2:DescribeSubnets', 'ec2:DescribeTags', 'ec2:DescribeVpcClassicLink', 'ec2:DescribeVpcs', 'sts:GetCallerIdentity'] 2022-11-14 12:08:37.342789 | controller | + ansible-playbook playbooks/create_inventory_config.yml -e 'template='\''inventory_with_hostvars_prefix_suffix.yml.j2'\''' -e 'hostvars_suffix='\''_aws_ec2'\''' -vvvv -e @/home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/config-file-4he3xb2k.json Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Renames aws_eks_cluster to eks_cluster in line with new naming guidelines
ISSUE TYPE
COMPONENT NAME
aws_eks_cluster
ADDITIONAL INFORMATION