Rename s3 modules #1271
Merged
Rename s3 modules #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
docs
feature
alinabuzachis
approved these changes
Jun 28, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Refactor inventory plugin connection handling SUMMARY Further refactors inventory plugin connection handling: Expands AWSPluginBase client() and resource() to allow overriding parameters renames _boto3_conn to all_clients to better describe what it's doing (_boto3_conn is used elswhere for singluar clients) assumes the IAM role once updates plugin parameters to match other plugins/modules updates RDS description wrapper to avoid reordering arguments avoids maintaining a full inventory scoped rewrite of client/resource code avoids maintaining a full inventory scoped handling of boto3/botocore version handling ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/inventory/aws_rds.py plugins/plugin_utils/base.py plugins/plugin_utils/inventory.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Rename s3 modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_s3_bucket_info and aws_s3_cors ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_s3_bucket_info.py plugins/modules/aws_s3_cors.py plugins/modules/s3_bucket_info.py plugins/modules/s3_cors.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@dd8b18e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In line with the naming guidelines, removes the
aws_prefix fromaws_s3_bucket_infoandaws_s3_corsISSUE TYPE
COMPONENT NAME
plugins/modules/aws_s3_bucket_info.py
plugins/modules/aws_s3_cors.py
plugins/modules/s3_bucket_info.py
plugins/modules/s3_cors.py
ADDITIONAL INFORMATION