Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam_role: drop deprecation #1636

Conversation

markuman
Copy link
Member

@markuman markuman commented Jan 4, 2023

SUMMARY

The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.

COMPONENT NAME

iam_role

@markuman markuman added backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch labels Jan 4, 2023
@markuman markuman requested a review from tremble January 4, 2023 07:36
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/community.aws/actions/runs/3836075950

You can compare to the docs for the main branch here:
https://ansible-collections.github.io/community.aws/branch/main

File changes:

  • M collections/community/aws/iam_role_module.html
Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/iam_role_module.html b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/iam_role_module.html
index 3bdc16a..8487e56 100644
--- a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/iam_role_module.html
+++ b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/iam_role_module.html
@@ -339,11 +339,10 @@ see <a class="reference internal" href="#ansible-collections-community-aws-iam-r
 <p class="ansible-option-type-line"><span class="ansible-option-type">boolean</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>When <em>purge_policies=true</em> any managed policies not listed in <em>managed_policies</em> will be detatched.</p>
-<p>By default <em>purge_policies=true</em>.  In a release after 2022-06-01 this will be changed to <em>purge_policies=false</em>.</p>
 <p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
 <ul class="simple">
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
-<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">true</span></code></p></li>
+<li><p><code class="ansible-option-default-bold docutils literal notranslate"><span class="pre">true</span></code> <span class="ansible-option-choices-default-mark">← (default)</span></p></li>
 </ul>
 </div></td>
 </tr>

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 5m 33s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 14m 20s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 16m 04s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 14m 19s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 58s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 00s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 02s
✔️ ansible-test-changelog SUCCESS in 2m 19s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 5m 53s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@ansibullbot
Copy link

@markuman: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 4, 2023
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 4, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 5m 14s
✔️ ansible-test-sanity-docker-devel SUCCESS in 14m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 48s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 20m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 10s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 45s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 21s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 32s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 01s
✔️ ansible-test-changelog SUCCESS in 2m 15s
✔️ ansible-test-splitter SUCCESS in 2m 48s
✔️ integration-community.aws-1 SUCCESS in 5m 15s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 75ba63b into ansible-collections:main Jan 4, 2023
@patchback
Copy link

patchback bot commented Jan 4, 2023

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/75ba63bec07d98e021fc204882c5b82c64027aeb/pr-1636

Backported as #1637

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
iam_role: drop deprecation

SUMMARY
The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.
COMPONENT NAME
iam_role

Reviewed-by: Mark Chappell <None>
(cherry picked from commit 75ba63b)
@patchback
Copy link

patchback bot commented Jan 4, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/75ba63bec07d98e021fc204882c5b82c64027aeb/pr-1636

Backported as #1638

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 4, 2023
iam_role: drop deprecation

SUMMARY
The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.
COMPONENT NAME
iam_role

Reviewed-by: Mark Chappell <None>
(cherry picked from commit 75ba63b)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 4, 2023
[PR #1636/75ba63be backport][stable-5] iam_role: drop deprecation

This is a backport of PR #1636 as merged into main (75ba63b).
SUMMARY
The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.
COMPONENT NAME
iam_role

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 4, 2023
[PR #1636/75ba63be backport][stable-4] iam_role: drop deprecation

This is a backport of PR #1636 as merged into main (75ba63b).
SUMMARY
The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.
COMPONENT NAME
iam_role

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
iam_role: drop deprecation

SUMMARY
The change was announced since community.aws 1.0.0 for ansible 2.14
With community.aws 2.1.0, it was changed to the date after 2022-06-01
However, in the meantime the standard value is true for purge parameters. Therefore we just drop the deprecation warning.
COMPONENT NAME
iam_role

Reviewed-by: Mark Chappell <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@75ba63b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch mergeit Merge the PR (SoftwareFactory) module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants