Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport stable-5 - ecs_cluster capacity provider strategy #1640 #1673 #1678

Conversation

markuman
Copy link
Member

backport #1640 ecs_cluster capacity provider strategy
#1640 (comment)

backport #1676

waiting for #1676

SUMMARY
Fixes #770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_cluster
ADDITIONAL INFORMATION
When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task:

  • name: Create an ECS Cluster with Capacity Providers ecs_cluster: name: default state: present capacity_providers: - FARGATE - FARGATE_SPOT capacity_provider_strategy: - capacity_provider: FARGATE base: 1 weight: 1 - capacity_provider: FARGATE_SPOT weight: 100

Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user.

Reviewed-by: Markus Bergholz [email protected]
Reviewed-by: Justin McCormick
Reviewed-by: Alina Buzachis

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

karcadia and others added 4 commits January 23, 2023 13:14
ecs_cluster capacity provider strategy

SUMMARY
Fixes ansible-collections#770 - Add AWS ECS_Cluster Capacity Provider Strategy Support
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_cluster
ADDITIONAL INFORMATION
When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user.
Given playbook task:
- name: Create an ECS Cluster with Capacity Providers
  ecs_cluster:
    name: default
    state: present
    capacity_providers:
      - FARGATE
      - FARGATE_SPOT
    capacity_provider_strategy:
      - capacity_provider: FARGATE
        base: 1
        weight: 1
      - capacity_provider: FARGATE_SPOT
        weight: 100

Previously would throw "Unsupported parameter" and no other parameter exists to expose these features.
Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user.

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Justin McCormick <None>
Reviewed-by: Alina Buzachis <None>
ecs_cluster: add default value to doc

SUMMARY
missing default value in the docs section of ansible-collections#1640
not released yet.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ecs_cluster

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
@markuman markuman changed the title Backport 1640 backport stable-5 - ecs_cluster capacity provider strategy #1640 #1673 Jan 23, 2023
@markuman markuman requested a review from tremble January 23, 2023 18:24
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jan 23, 2023
@github-actions
Copy link

github-actions bot commented Jan 23, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 6m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 53s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 57s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 09s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 42s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 54s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 01s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 05s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 59s
✔️ ansible-test-changelog SUCCESS in 2m 33s
✔️ ansible-test-splitter SUCCESS in 2m 51s
✔️ integration-community.aws-1 SUCCESS in 4m 45s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 23, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 6m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 43s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 53s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 11s
ansible-test-sanity-docker-stable-2.14 RETRY_LIMIT in 1m 35s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 50s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 59s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 20s
✔️ ansible-test-changelog SUCCESS in 2m 30s
✔️ ansible-test-splitter SUCCESS in 2m 46s
✔️ integration-community.aws-1 SUCCESS in 5m 05s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@markuman markuman added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jan 23, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 5m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 48s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 45s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 49s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 40s
✔️ ansible-test-changelog SUCCESS in 2m 33s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-community.aws-1 SUCCESS in 5m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 93b599c into ansible-collections:stable-5 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants