-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport stable-5 - ecs_cluster capacity provider strategy #1640 #1673 #1678
Merged
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:stable-5
from
markuman:backport-1640
Jan 23, 2023
Merged
backport stable-5 - ecs_cluster capacity provider strategy #1640 #1673 #1678
softwarefactory-project-zuul
merged 4 commits into
ansible-collections:stable-5
from
markuman:backport-1640
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecs_cluster capacity provider strategy SUMMARY Fixes ansible-collections#770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_cluster ADDITIONAL INFORMATION When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task: - name: Create an ECS Cluster with Capacity Providers ecs_cluster: name: default state: present capacity_providers: - FARGATE - FARGATE_SPOT capacity_provider_strategy: - capacity_provider: FARGATE base: 1 weight: 1 - capacity_provider: FARGATE_SPOT weight: 100 Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Justin McCormick <None> Reviewed-by: Alina Buzachis <None>
ecs_cluster: add default value to doc SUMMARY missing default value in the docs section of ansible-collections#1640 not released yet. ISSUE TYPE Docs Pull Request COMPONENT NAME ecs_cluster Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
markuman
changed the title
Backport 1640
backport stable-5 - ecs_cluster capacity provider strategy #1640 #1673
Jan 23, 2023
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
labels
Jan 23, 2023
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jan 23, 2023
markuman
added
mergeit
Merge the PR (SoftwareFactory)
and removed
mergeit
Merge the PR (SoftwareFactory)
labels
Jan 23, 2023
softwarefactory-project-zuul
bot
merged commit Jan 23, 2023
93b599c
into
ansible-collections:stable-5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #1640 ecs_cluster capacity provider strategy
#1640 (comment)
backport #1676
waiting for #1676
SUMMARY
Fixes #770 - Add AWS ECS_Cluster Capacity Provider Strategy Support ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ecs_cluster
ADDITIONAL INFORMATION
When creating or updating an ECS Cluster, configure the capacity providers and capacity provider strategy as provided by the user. Given playbook task:
Previously would throw "Unsupported parameter" and no other parameter exists to expose these features. Now you should see changed: [localhost] with the resultant created ECS Cluster having the same providers and provider_strategy fields as provided by the user.
Reviewed-by: Markus Bergholz [email protected]
Reviewed-by: Justin McCormick
Reviewed-by: Alina Buzachis
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION