ecs: integration test and new purge parameters #1716
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
bug
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 48s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 32s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 35s |
tests/integration/targets/ecs_cluster/tasks/01_create_requirements.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ecs_cluster/tasks/01_create_requirements.yml
Outdated
Show resolved
Hide resolved
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 05s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 55s |
|
regate |
|
regate |
|
We have a theory (thanks, @tremble) that we may need to add a pause after the iam_role update task in 20_ecs_service.yml. We were seeing this kind of inconsistent role assumption while testing the CI policies as well. @gravesm and I will try that with local tests for several iterations and report back. |
tests/integration/targets/ecs_cluster/tasks/99_terminate_everything.yml
Outdated
Show resolved
Hide resolved
|
I've run this twice now with a pause after the problem role creation, once with a 60 second pause and once with a 30 second pause. In both cases, it passed, which is the first time I've been able to get this test suite to pass, locally. Let's see what @jillr's results look like, but from my perspective the pause seems to do the trick. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 53s |
|
I'm running with a 20 second pause at tests/integration/targets/ecs_cluster/tasks/20_ecs_service.yml line 674 and so far all successful. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 25s |
markuman
added
mergeit
|
regate |
|
regate |
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 45s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1731 🤖 @patchback |
ecs: integration test and new purge parameters SUMMARY Make the ecs_cluster integration test work again ecs_service - new parameter purge_placement_constraints and purge_placement_strategy. Otherwise it is impossible to remove those placements without breaking backwards compatibility. purge_placement_constraints in the integration test purge_placement_strategy in the integration test required by mattclay/aws-terminator#210 (comment) ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION works for me again ansible-test integration --python 3.10 ecs_cluster --docker --allow-unsupported ... PLAY RECAP ********************************************************************* testhost : ok=143 changed=69 unreachable=0 failed=0 skipped=1 rescued=0 ignored=6 Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 86c60b4)
[PR #1716/86c60b49 backport][stable-5] ecs: integration test and new purge parameters This is a backport of PR #1716 as merged into main (86c60b4). SUMMARY Make the ecs_cluster integration test work again ecs_service - new parameter purge_placement_constraints and purge_placement_strategy. Otherwise it is impossible to remove those placements without breaking backwards compatibility. purge_placement_constraints in the integration test purge_placement_strategy in the integration test required by mattclay/aws-terminator#210 (comment) ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION works for me again ansible-test integration --python 3.10 ecs_cluster --docker --allow-unsupported ... PLAY RECAP ********************************************************************* testhost : ok=143 changed=69 unreachable=0 failed=0 skipped=1 rescued=0 ignored=6 Reviewed-by: Mark Chappell
…r. (ansible-collections#1716) Update document to use no_log and register when creating a new keypair SUMMARY "When creating a new keypair the ec2_key module prints out the private key directly to the standard output. This makes it unusable in any kind of public workflow." To fix this security vulnerability no_log and register should be used while using this module to create a keypair. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Alina Buzachis
Bump 2024 deprecations from dates to release versions SUMMARY Bump 2024 deprecations from dates to release versions ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/ecs_cluster.py plugins/modules/ecs_service.py plugins/modules/glue_connection.py ADDITIONAL INFORMATION See also: #518 #1640 #1716 Reviewed-by: Alina Buzachis
SUMMARY
purge_placement_constraintsandpurge_placement_strategy. Otherwise it is impossible to remove those placements without breaking backwards compatibility.ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
works for me again