-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamoDB - add waiter for secondary indexes #1866
DynamoDB - add waiter for secondary indexes #1866
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 58s (non-voting) |
8c98948
to
28bb0fd
Compare
@@ -870,9 +855,6 @@ def _update_table(current_table): | |||
additional_global_index_changes=additional_global_index_changes, | |||
) | |||
|
|||
if module.params.get("wait"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed, the wait logic is going to be called again in the only place that _update_table()
is called.
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 25s (non-voting) |
28bb0fd
to
793b6fb
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 33s (non-voting) |
793b6fb
to
5080067
Compare
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 04s (non-voting) |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 33s (non-voting) |
0740783
to
4146cd7
Compare
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 4m 21s (non-voting) |
Build succeeded (gate pipeline). ❌ ansible-galaxy-importer FAILURE in 4m 04s (non-voting) |
Pull request merge failed: Required status check "ansible/gate" is expected. |
4146cd7
to
62f56c2
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 23s (non-voting) |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 12s (non-voting) |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1870 🤖 @patchback |
DynamoDB - add waiter for secondary indexes SUMMARY Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress) Adds a waiter for the indexes ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit 6fdbd75)
[PR #1866/6fdbd753 backport][stable-6] DynamoDB - add waiter for secondary indexes This is a backport of PR #1866 as merged into main (6fdbd75). SUMMARY Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress) Adds a waiter for the indexes ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY
Integration tests keep failing due to concurrency issues (the service doesn't like making updates while index updates are in progress)
Adds a waiter for the indexes
ISSUE TYPE
COMPONENT NAME
dynamodb_table
ADDITIONAL INFORMATION