-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connection): get bucket_region in aws_ssm #1908
fix(connection): get bucket_region in aws_ssm #1908
Conversation
@Hokwang this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 44s (non-voting) |
Is it possible for anyone to review this? |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 53s (non-voting) |
when bucket is in us-east-1, bucket_location["LocationConstraint"] is null
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 06s (non-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to submit this PR, please add a changelog fragment:
https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s (non-voting) |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 52s (non-voting) |
5224601
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2043 🤖 @patchback |
fix(connection): get bucket_region in aws_ssm SUMMARY when bucket is in us-east-1, bucket_location["LocationConstraint"] is null ISSUE TYPE Bugfix Pull Request COMPONENT NAME connection ADDITIONAL INFORMATION add condition for bucket_region Reviewed-by: Mark Chappell (cherry picked from commit 5224601)
[PR #1908/5224601b backport][stable-7] fix(connection): get bucket_region in aws_ssm This is a backport of PR #1908 as merged into main (5224601). SUMMARY when bucket is in us-east-1, bucket_location["LocationConstraint"] is null ISSUE TYPE Bugfix Pull Request COMPONENT NAME connection ADDITIONAL INFORMATION add condition for bucket_region Reviewed-by: Mark Chappell
SUMMARY
when bucket is in us-east-1,
bucket_location["LocationConstraint"]
is nullISSUE TYPE
COMPONENT NAME
connection
ADDITIONAL INFORMATION
add condition for
bucket_region