Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_instance - Apply retry decorators more consistently. #373

Merged
merged 4 commits into from
Feb 3, 2021
Merged

ec2_instance - Apply retry decorators more consistently. #373

merged 4 commits into from
Feb 3, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 27, 2021

SUMMARY

Improve the stability of ec2_instance:

  • Wrap paginator calls in a function so we can use AWSRetry
  • Use aws_retry_decorator when creating ec2 clients
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @Shaps @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jan 27, 2021
@tremble tremble requested a review from jillr January 29, 2021 13:08
@jillr jillr merged commit bbb4707 into ansible-collections:main Feb 3, 2021
@tremble tremble deleted the stability/ec2_instance-pagination branch February 11, 2021 09:11
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
ec2_instance - Apply retry decorators more consistently. (ansible-col…
83b5a13 
…lections#373)

* ec2_instance: build results inside find_instances and add backoff

* Add retry decorator to ec2 clients
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
ec2_instance - Apply retry decorators more consistently. (ansible-col…
e7ee443 
…lections#373)

* ec2_instance: build results inside find_instances and add backoff

* Add retry decorator to ec2 clients
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@tremble @danielcotton
ec2_instance - Apply retry decorators more consistently. (ansible-col…
67c8dab 
…lections#373)

* ec2_instance: build results inside find_instances and add backoff

* Add retry decorator to ec2 clients
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble @jillr
ec2_instance - Apply retry decorators more consistently. (ansible-col…
584c387 
…lections#373)

* ec2_instance: build results inside find_instances and add backoff

* Add retry decorator to ec2 clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @jillr