Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iam_saml_federation - return details of provider when no changes are made #419

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 17, 2021

SUMMARY
  • Checks basic details of provider in return values
  • Enables the tests in CI
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_saml_federation

ADDITIONAL INFORMATION

Blocked by mattclay/aws-terminator#125

@ansibullbot
Copy link

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests labels Feb 17, 2021
@tremble tremble changed the title [CI Policy] iam_saml_federation - return details of provider when no changes are made iam_saml_federation - return details of provider when no changes are made Feb 19, 2021
@tremble tremble requested a review from jillr February 19, 2021 18:01
@jillr
Copy link
Collaborator

jillr commented Feb 19, 2021

@tremble Because tests for this module were never enabled in CI before we've missed that iam_saml_federation is not in 2.9's lib/ansible/config/module_defaults.yml. You'll need to open a PR to stable-2.9 to use mod_defaults in this test suite.
Otherwise this change looks good.

@tremble
Copy link
Contributor Author

tremble commented Feb 20, 2021

ansible/ansible#73669 submitted to add to module_defaults.

@tremble
Copy link
Contributor Author

tremble commented Mar 8, 2021

Tests now working (2.9 defaults updated) merging based on @jillr's "change looks good"

@tremble tremble merged commit 9d436d0 into ansible-collections:main Mar 8, 2021
danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
…made (ansible-collections#419)

* iam_saml_federation - return details of provider when no changes are made.
* iam_saml_federation - enable integration tests
@tremble tremble deleted the iam_saml_federation/not-changed-results branch June 29, 2021 12:55
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…made (ansible-collections#419)

* iam_saml_federation - return details of provider when no changes are made.
* iam_saml_federation - enable integration tests
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
…made (ansible-collections#419)

* iam_saml_federation - return details of provider when no changes are made.
* iam_saml_federation - enable integration tests
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
…made (ansible-collections#419)

* iam_saml_federation - return details of provider when no changes are made.
* iam_saml_federation - enable integration tests
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
Add note to use FQCN on Ansible versions <1.10

SUMMARY
Updates aws_rds inventory module documentation to add a note for uses of Ansible versions prior to 1.10 to use the fully qualified collection name to avoid issues with role assumption (Addresses ansible-collections#415 )
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_rds

Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants