Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_peering_info - Add AWSRetry decorator #536

Merged
merged 3 commits into from
Apr 12, 2021
Merged

ec2_vpc_peering_info - Add AWSRetry decorator #536

merged 3 commits into from
Apr 12, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 10, 2021

SUMMARY
  • Add AWSRetry decorator
  • Use common normalize_boto3_result code instead of C&P
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_peering_info

ADDITIONAL INFORMATION

@tremble tremble requested review from jillr and alinabuzachis April 10, 2021 08:02
@ansibullbot
Copy link

cc @Etherdaemon @jillr @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels Apr 10, 2021
@tremble tremble force-pushed the ec2_vpc_peering_info/retries branch from 1c848e2 to d300f89 Compare April 10, 2021 08:08
@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Apr 10, 2021

Starting check jobs.
Warning:
Failed to update check run ansible/check: 500 [No message]

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Apr 10, 2021
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 10, 2021
@tremble tremble force-pushed the ec2_vpc_peering_info/retries branch from d300f89 to 5afb687 Compare April 10, 2021 08:34
alinabuzachis
alinabuzachis approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tremble tremble added the gate label Apr 12, 2021
@ansible-zuul ansible-zuul bot merged commit ba65e39 into ansible-collections:main Apr 12, 2021
@tremble tremble deleted the ec2_vpc_peering_info/retries branch June 29, 2021 12:58
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#536 from tremble/ec2…
652a808 
…_vpc_peering_info/retries

ec2_vpc_peering_info - Add AWSRetry decorator

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@ba65e39
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#536 from tremble/ec2_vpc_peeri…
1cd3938 
…ng_info/retries

ec2_vpc_peering_info - Add AWSRetry decorator

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#536 from tremble/ec2_vpc_peeri…
9ef0b33 
…ng_info/retries

ec2_vpc_peering_info - Add AWSRetry decorator

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@mandar242
ec2_instance: Add count parameter to ec2_instance (ansible-collection…
760186c 
…s#539)

ec2_instance: Add count parameter to ec2_instance

SUMMARY


Adding min_count and max_count parameter to ec2_instance.
Fixes ansible-collections#536.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance

Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @alinabuzachis