Added support for InputTransformer attribute of cloudwatchevent_rule #623

avishayil · 2021-07-03T18:07:15Z

SUMMARY

EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

aws.cloudwatchevent_rule

ADDITIONAL INFORMATION

    ...
        "targets": [
            {
                "arn": "arn:aws:sns:us-east-1:123456789012:MySNSTopic",
                "id": "MySNSTopic",
                "input_transformer": {
                    "input_paths_map": {
                        "instance": "$.detail.instance-id",
                        "state": "$.detail.state"
                    },
                    "input_template": "\"<instance> is in state <state>\""
                }
            }
        ]

ansibullbot · 2021-07-03T18:17:07Z

cc @jillr @jsdalton @s-hertel @tremble @wimnat
click here for bot help

markuman

LGTM.
Unfortunately we still have no integrationtests for cloudwatchevent_rule.
Do you find some time to add them?

plugins/modules/cloudwatchevent_rule.py

avishayil · 2021-07-07T19:36:23Z

LGTM.
Unfortunately we still have no integrationtests for cloudwatchevent_rule.
Do you find some time to add them?

Sure, do you want me to do it in the context of this PR or on another PR?

markuman · 2021-07-08T05:01:06Z

LGTM.
Unfortunately we still have no integrationtests for cloudwatchevent_rule.
Do you find some time to add them?

Sure, do you want me to do it in the context of this PR or on another PR?

the same is fine.

avishayil · 2021-07-09T11:48:22Z

@markuman I added integration tests, please review.

The automated tests are failing for authorization and timeouts, things I cannot really control

alinabuzachis

@avishayil Thank you very much for taking the time to work on this. Overall this looks good to me. For the authorization errors, there is required a policy for DescribeRule to be added in the terminator https://github.com/mattclay/aws-terminator. Would you be willing to open a PR in the terminator https://github.com/mattclay/aws-terminator to add this policy? Let me know if you need any help, otherwise I can add it for you.

plugins/modules/cloudwatchevent_rule.py

avishayil · 2021-07-09T14:16:09Z

@avishayil Thank you very much for taking the time to work on this. Overall this looks good to me. For the authorization errors, there is required a policy for DescribeRule to be added in the terminator https://github.com/mattclay/aws-terminator. Would you be willing to open a PR in the terminator https://github.com/mattclay/aws-terminator to add this policy? Let me know if you need any help, otherwise I can add it for you.

Hi @alinabuzachis,

I wasn't sure under what yaml file should I add the permission, but here's the PR:
mattclay/aws-terminator#155

Regarding the version_added, I added it, however I didn't find any similar pattern in some random modules I browsed to get some reference on how to do it, so let me know if it's ok. Relevant commit: avishayil@2c71f9e

Regarding the timeout, any idea?

tests/integration/targets/cloudwatchevent_rule/defaults/main.yml

ansibullbot · 2021-07-16T13:44:23Z

@avishayil this PR contains the following merge commits:

3e85acc

Please rebase your branch to remove these commits.

click here for bot help

avishayil · 2021-07-16T20:34:11Z

@avishayil this PR contains the following merge commits:
* [3e85acc](https://github.com/ansible-collections/community.aws/commit/3e85acc1eafb1b5f7b3b2f6a284ee3a543a48d6c)
Please rebase your branch to remove these commits.

click here for bot help

rebased

jillr · 2021-07-22T22:49:15Z

recheck

avishayil · 2021-07-23T06:00:46Z

recheck

I think the docs error in zuul is unrelated to this PR?

avishayil · 2021-07-30T05:51:24Z

recheck

Any progress?

avishayil · 2021-08-04T21:16:07Z

Hi @jillr @markuman any news?

alinabuzachis · 2022-02-08T09:57:33Z

recheck

softwarefactory-project-zuul · 2022-02-08T10:16:12Z

Build succeeded.

ansible-galaxy-importer : FAILURE in 4m 22s (non-voting)
build-ansible-collection : SUCCESS in 3m 27s
ansible-test-sanity-docker-devel : SUCCESS in 10m 53s (non-voting)
ansible-test-sanity-docker-milestone : SUCCESS in 11m 34s
ansible-test-sanity-docker-stable-2.9 : SUCCESS in 13m 55s
ansible-test-sanity-docker-stable-2.11 : SUCCESS in 11m 45s
ansible-test-sanity-docker-stable-2.12 : SUCCESS in 10m 42s
ansible-test-units-community-aws-python38 : SUCCESS in 8m 16s
ansible-test-splitter : SUCCESS in 5m 49s
ansible-test-cloud-integration-aws-py38_0 : SUCCESS in 6m 53s
ansible-test-cloud-integration-aws-py38_1 : SKIPPED
ansible-test-cloud-integration-aws-py38_2 : SKIPPED
ansible-test-cloud-integration-aws-py38_3 : SKIPPED
ansible-test-cloud-integration-aws-py38_4 : SKIPPED
ansible-test-cloud-integration-aws-py38_5 : SKIPPED

avishayil · 2022-02-08T15:15:35Z

Hi @alinabuzachis happy to see we're back on track!

alinabuzachis · 2022-05-06T09:26:05Z

recheck

softwarefactory-project-zuul · 2022-05-06T09:46:13Z

Build succeeded.

tremble · 2022-07-05T15:14:37Z

recheck

EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage.

tremble

Thanks for adding the minimal integration tests.

I'm sorry this has taken so long, assuming the tests pass I think this is ready to merge.

github-actions · 2022-07-05T15:37:05Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-07-05T15:42:06Z

Build succeeded.

avishayil · 2022-07-05T15:58:08Z

Thanks, it's been over a year 🙏

softwarefactory-project-zuul · 2022-07-05T16:02:57Z

Build succeeded (gate pipeline).

patchback · 2022-07-15T07:05:59Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/bd097b5e0f02d471e7ed786a0743ce48844b60c7/pr-623

Backported as #1357

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…623) Added support for InputTransformer attribute of cloudwatchevent_rule SUMMARY EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage. ISSUE TYPE Feature Pull Request COMPONENT NAME aws.cloudwatchevent_rule ADDITIONAL INFORMATION ... "targets": [ { "arn": "arn:aws:sns:us-east-1:123456789012:MySNSTopic", "id": "MySNSTopic", "input_transformer": { "input_paths_map": { "instance": "$.detail.instance-id", "state": "$.detail.state" }, "input_template": "\"<instance> is in state <state>\"" } } ] Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Avishay Bar <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit bd097b5)

…623) (#1357) [PR #623/bd097b5e backport][stable-4] Added support for InputTransformer attribute of cloudwatchevent_rule This is a backport of PR #623 as merged into main (bd097b5). SUMMARY EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage. ISSUE TYPE Feature Pull Request COMPONENT NAME aws.cloudwatchevent_rule ADDITIONAL INFORMATION ... "targets": [ { "arn": "arn:aws:sns:us-east-1:123456789012:MySNSTopic", "id": "MySNSTopic", "input_transformer": { "input_paths_map": { "instance": "$.detail.instance-id", "state": "$.detail.state" }, "input_template": "\"<instance> is in state <state>\"" } } ] Reviewed-by: Mark Chappell <None>

Fix support envvars for lookup aws ssm SUMMARY Took over from ansible-collections#623 to apply reviewer's comments and add a changelog fragment. Working on support in lookup plugin amazon.aws.aws_ssm for endpoint parameters, as well of tradional environment variable for client configuration (AWS_PROFILE, AWS_ACCESS_KEY_ID, ...). This should fixes ansible-collections#519 Depends-On: ansible-collections#728 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION It seems LookupModule cannot benefit from AnsibleAWSModule (it expect several methods/params, I am not familiar enough with Python and Ansible to sort it out) ; so this PR uses boto3_conn and get_aws_connection_info defined in utils.ec2. This is a simple snippet how it can be used: - name: Load env collections: - amazon.aws gather_facts: no hosts: localhost connection: local vars: my_env: "{{ lookup('amazon.aws.aws_ssm', 'status', endpoint='http://localhost:4566') }}" tasks: - name: show the env debug: msg: "{{ my_env }}" Command line test: ANSIBLE_COLLECTIONS_PATHS=${ANSIBLE_HOME}/collections ansible-playbook test.yml Output: PLAY [Load env] ************************************************************************************************************************************************************************************************************************************************************* TASK [show the env] ********************************************************************************************************************************************************************************************************************************************************* ok: [localhost] => { "msg": "INIT" } PLAY RECAP ****************************************************************************************************************************************************************************************************************************************************************** localhost : ok=1 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 Another test with envars: AWS_ACCESS_KEY_ID='foo' AWS_ACCESS_SECRET_KEY='bar' AWS_URL='http://localhost:4566' ANSIBLE_COLLECTIONS_PATHS=${ANSIBLE_HOME}/collections ansible-playbook test.yml where we remove the endpoint from lookup: - name: Load env collections: - amazon.aws gather_facts: no hosts: localhost connection: local vars: my_env: "{{ lookup('amazon.aws.aws_ssm', 'status') }}" tasks: - name: show the env debug: msg: "{{ my_env }}" (provides same output) Reviewed-by: Mark Chappell <None>

…nsible-collections#623) Added support for InputTransformer attribute of cloudwatchevent_rule SUMMARY EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage. ISSUE TYPE Feature Pull Request COMPONENT NAME aws.cloudwatchevent_rule ADDITIONAL INFORMATION ... "targets": [ { "arn": "arn:aws:sns:us-east-1:123456789012:MySNSTopic", "id": "MySNSTopic", "input_transformer": { "input_paths_map": { "instance": "$.detail.instance-id", "state": "$.detail.state" }, "input_template": "\"<instance> is in state <state>\"" } } ] Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Avishay Bar <[email protected]> Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@bd097b5

ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 3, 2021

markuman approved these changes Jul 7, 2021

View reviewed changes

plugins/modules/cloudwatchevent_rule.py Show resolved Hide resolved

ansibullbot removed the needs_triage label Jul 9, 2021

avishayil force-pushed the patch-1 branch from 46f60cf to 6d8215f Compare July 9, 2021 11:31

ansibullbot added integration tests/integration tests tests labels Jul 9, 2021

alinabuzachis reviewed Jul 9, 2021

View reviewed changes

plugins/modules/cloudwatchevent_rule.py Show resolved Hide resolved

avishayil mentioned this pull request Jul 9, 2021

Added describe event rule permission mattclay/aws-terminator#155

Merged

jillr reviewed Jul 15, 2021

View reviewed changes

tests/integration/targets/cloudwatchevent_rule/defaults/main.yml Outdated Show resolved Hide resolved

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed community_review labels Jul 16, 2021

avishayil force-pushed the patch-1 branch from 3e85acc to 704f9c6 Compare July 16, 2021 20:33

ansibullbot added community_review and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jul 16, 2021

avishayil force-pushed the patch-1 branch from 704f9c6 to 0d5b4b1 Compare July 19, 2021 20:06

avishayil and others added 4 commits July 5, 2022 17:17

Added support for InputTransformer attribute of cloudwatchevent_rule

ae2034a

EventBridge has the InputTransformer attribute on target to allow providing custom input to a target based on certain event data. This PR adds this functionality and includes an example usage.

Added integration tests

f1e0949

Update cloudwatchevent_rule.py

457817b

bitrot

fb7f731

tremble force-pushed the patch-1 branch from 0d5b4b1 to fb7f731 Compare July 5, 2022 15:22

Add link to changelog

99acf23

tremble approved these changes Jul 5, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 5, 2022

softwarefactory-project-zuul bot merged commit bd097b5 into ansible-collections:main Jul 5, 2022

tremble added the backport-4 PR should be backported to the stable-4 branch label Jul 15, 2022

patchback bot mentioned this pull request Jul 15, 2022

[PR #623/bd097b5e backport][stable-4] Added support for InputTransformer attribute of cloudwatchevent_rule #1357

Merged

renovate bot mentioned this pull request Aug 8, 2022

chore(deps): update dependency community.aws to v4.1.1 linxside/ansible-ee#44

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for InputTransformer attribute of cloudwatchevent_rule #623

Added support for InputTransformer attribute of cloudwatchevent_rule #623

avishayil commented Jul 3, 2021 •

edited

Loading

ansibullbot commented Jul 3, 2021

markuman left a comment

avishayil commented Jul 7, 2021

markuman commented Jul 8, 2021

avishayil commented Jul 9, 2021 •

edited

Loading

alinabuzachis left a comment •

edited

Loading

avishayil commented Jul 9, 2021 •

edited

Loading

ansibullbot commented Jul 16, 2021

avishayil commented Jul 16, 2021

jillr commented Jul 22, 2021

avishayil commented Jul 23, 2021

avishayil commented Jul 30, 2021

avishayil commented Aug 4, 2021

alinabuzachis commented Feb 8, 2022

softwarefactory-project-zuul bot commented Feb 8, 2022

avishayil commented Feb 8, 2022

alinabuzachis commented May 6, 2022

softwarefactory-project-zuul bot commented May 6, 2022

tremble commented Jul 5, 2022

tremble left a comment

github-actions bot commented Jul 5, 2022 •

edited

Loading

softwarefactory-project-zuul bot commented Jul 5, 2022

avishayil commented Jul 5, 2022

softwarefactory-project-zuul bot commented Jul 5, 2022

patchback bot commented Jul 15, 2022 •

edited

Loading

Added support for InputTransformer attribute of cloudwatchevent_rule #623

Added support for InputTransformer attribute of cloudwatchevent_rule #623

Conversation

avishayil commented Jul 3, 2021 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jul 3, 2021

markuman left a comment

Choose a reason for hiding this comment

avishayil commented Jul 7, 2021

markuman commented Jul 8, 2021

avishayil commented Jul 9, 2021 • edited Loading

alinabuzachis left a comment • edited Loading

Choose a reason for hiding this comment

avishayil commented Jul 9, 2021 • edited Loading

ansibullbot commented Jul 16, 2021

avishayil commented Jul 16, 2021

jillr commented Jul 22, 2021

avishayil commented Jul 23, 2021

avishayil commented Jul 30, 2021

avishayil commented Aug 4, 2021

alinabuzachis commented Feb 8, 2022

softwarefactory-project-zuul bot commented Feb 8, 2022

avishayil commented Feb 8, 2022

alinabuzachis commented May 6, 2022

softwarefactory-project-zuul bot commented May 6, 2022

tremble commented Jul 5, 2022

tremble left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2022 • edited Loading

Docs Build 📝

softwarefactory-project-zuul bot commented Jul 5, 2022

avishayil commented Jul 5, 2022

softwarefactory-project-zuul bot commented Jul 5, 2022

patchback bot commented Jul 15, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

avishayil commented Jul 3, 2021 •

edited

Loading

avishayil commented Jul 9, 2021 •

edited

Loading

alinabuzachis left a comment •

edited

Loading

avishayil commented Jul 9, 2021 •

edited

Loading

github-actions bot commented Jul 5, 2022 •

edited

Loading

patchback bot commented Jul 15, 2022 •

edited

Loading