Cleanup / unused imports #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some unittest magic involved
tremble
force-pushed
the
cleanup/unsed-imports
branch
from
73ad2b5 to
fe960ac
Compare
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
Jul 9, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
recheck |
|
The test issue looks like a bad CentOS mirror that should now be fixed. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…anup/unsed-imports Cleanup / unused imports SUMMARY Running a slightly more nit-picky pylint picked up on a number of unused imports. For general code cleanliness we should clean these up. (When we don't, we often see things copied and pasted all over the place) Also reorders various imports (in the same files) based on the recommendations from PEP. splits imports (in the same files) onto single lines to make rebase-conflicts easier to fix. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_endpoint.py plugins/modules/ec2_vpc_endpoint_info.py plugins/modules/ec2_vpc_peering_info.py plugins/modules/kinesis_stream.py plugins/modules/wafv2_ip_set.py plugins/modules/wafv2_ip_set_info.py plugins/modules/wafv2_resources.py plugins/modules/wafv2_resources_info.py plugins/modules/wafv2_rule_group.py plugins/modules/wafv2_rule_group_info.py plugins/modules/wafv2_web_acl.py plugins/modules/wafv2_web_acl_info.py scripts/inventory/ec2.py tests/unit/compat/builtins.py tests/unit/plugins/modules/test_aws_acm.py tests/unit/plugins/modules/test_aws_direct_connect_confirm_connection.py tests/unit/plugins/modules/test_aws_direct_connect_connection.py tests/unit/plugins/modules/test_aws_direct_connect_link_aggregation_group.py tests/unit/plugins/modules/test_aws_direct_connect_virtual_interface.py tests/unit/plugins/modules/test_data_pipeline.py tests/unit/plugins/modules/test_ec2_vpc_vpn.py tests/unit/plugins/modules/test_lambda.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@2463775
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…-imports Cleanup / unused imports SUMMARY Running a slightly more nit-picky pylint picked up on a number of unused imports. For general code cleanliness we should clean these up. (When we don't, we often see things copied and pasted all over the place) Also reorders various imports (in the same files) based on the recommendations from PEP. splits imports (in the same files) onto single lines to make rebase-conflicts easier to fix. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_endpoint.py plugins/modules/ec2_vpc_endpoint_info.py plugins/modules/ec2_vpc_peering_info.py plugins/modules/kinesis_stream.py plugins/modules/wafv2_ip_set.py plugins/modules/wafv2_ip_set_info.py plugins/modules/wafv2_resources.py plugins/modules/wafv2_resources_info.py plugins/modules/wafv2_rule_group.py plugins/modules/wafv2_rule_group_info.py plugins/modules/wafv2_web_acl.py plugins/modules/wafv2_web_acl_info.py scripts/inventory/ec2.py tests/unit/compat/builtins.py tests/unit/plugins/modules/test_aws_acm.py tests/unit/plugins/modules/test_aws_direct_connect_confirm_connection.py tests/unit/plugins/modules/test_aws_direct_connect_connection.py tests/unit/plugins/modules/test_aws_direct_connect_link_aggregation_group.py tests/unit/plugins/modules/test_aws_direct_connect_virtual_interface.py tests/unit/plugins/modules/test_data_pipeline.py tests/unit/plugins/modules/test_ec2_vpc_vpn.py tests/unit/plugins/modules/test_lambda.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…-imports Cleanup / unused imports SUMMARY Running a slightly more nit-picky pylint picked up on a number of unused imports. For general code cleanliness we should clean these up. (When we don't, we often see things copied and pasted all over the place) Also reorders various imports (in the same files) based on the recommendations from PEP. splits imports (in the same files) onto single lines to make rebase-conflicts easier to fix. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_endpoint.py plugins/modules/ec2_vpc_endpoint_info.py plugins/modules/ec2_vpc_peering_info.py plugins/modules/kinesis_stream.py plugins/modules/wafv2_ip_set.py plugins/modules/wafv2_ip_set_info.py plugins/modules/wafv2_resources.py plugins/modules/wafv2_resources_info.py plugins/modules/wafv2_rule_group.py plugins/modules/wafv2_rule_group_info.py plugins/modules/wafv2_web_acl.py plugins/modules/wafv2_web_acl_info.py scripts/inventory/ec2.py tests/unit/compat/builtins.py tests/unit/plugins/modules/test_aws_acm.py tests/unit/plugins/modules/test_aws_direct_connect_confirm_connection.py tests/unit/plugins/modules/test_aws_direct_connect_connection.py tests/unit/plugins/modules/test_aws_direct_connect_link_aggregation_group.py tests/unit/plugins/modules/test_aws_direct_connect_virtual_interface.py tests/unit/plugins/modules/test_data_pipeline.py tests/unit/plugins/modules/test_ec2_vpc_vpn.py tests/unit/plugins/modules/test_lambda.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Running a slightly more nit-picky pylint picked up on a number of unused imports. For general code cleanliness we should clean these up. (When we don't, we often see things copied and pasted all over the place)
Also
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_vpc_endpoint.py
plugins/modules/ec2_vpc_endpoint_info.py
plugins/modules/ec2_vpc_peering_info.py
plugins/modules/kinesis_stream.py
plugins/modules/wafv2_ip_set.py
plugins/modules/wafv2_ip_set_info.py
plugins/modules/wafv2_resources.py
plugins/modules/wafv2_resources_info.py
plugins/modules/wafv2_rule_group.py
plugins/modules/wafv2_rule_group_info.py
plugins/modules/wafv2_web_acl.py
plugins/modules/wafv2_web_acl_info.py
scripts/inventory/ec2.py
tests/unit/compat/builtins.py
tests/unit/plugins/modules/test_aws_acm.py
tests/unit/plugins/modules/test_aws_direct_connect_confirm_connection.py
tests/unit/plugins/modules/test_aws_direct_connect_connection.py
tests/unit/plugins/modules/test_aws_direct_connect_link_aggregation_group.py
tests/unit/plugins/modules/test_aws_direct_connect_virtual_interface.py
tests/unit/plugins/modules/test_data_pipeline.py
tests/unit/plugins/modules/test_ec2_vpc_vpn.py
tests/unit/plugins/modules/test_lambda.py
ADDITIONAL INFORMATION