Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_role: replace UpdateRoleDescription with use UpdateRole #697

Merged
merged 3 commits into from
Aug 24, 2021
Merged

iam_role: replace UpdateRoleDescription with use UpdateRole #697

merged 3 commits into from
Aug 24, 2021

Conversation

mandar242
Copy link
Contributor

SUMMARY

Modified iam_role.py to replace update_role_description (deprecated) with update_role action call.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_role

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review labels Aug 24, 2021
@mandar242 mandar242 changed the title iam_role.py: replace UpdateRoleDescription with use UpdateRole iam_role: replace UpdateRoleDescription with use UpdateRole Aug 24, 2021
tremble
tremble approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. update_role looks like it was added in 1.9.19 (well within the collection's 'supported' range but a couple of years after the role was originally added).

I've not run the test suite. To any other reviewers: please run the test suite prior to gating.

@tremble tremble linked an issue Aug 24, 2021 that may be closed by this pull request
Update iam_role.update_role_description to use UpdateRole action #204
Closed
@mandar242 mandar242 requested a review from jillr August 24, 2021 17:46
jillr
jillr reviewed Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a non-CI account (since we dom't allow IAM tests in CI). Passes and lgtm with the minor review request.

changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml Outdated Show resolved Hide resolved
@jillr jillr added the gate label Aug 24, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 24940d4 into ansible-collections:main Aug 24, 2021
@mandar242 mandar242 deleted the issues-204-update-iam-role branch August 25, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@jillr jillr jillr approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update iam_role.update_role_description to use UpdateRole action
4 participants
@mandar242 @ansibullbot @tremble @jillr