add TargetTrackingScaling as a scaling policy option
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
jillr
reviewed
Oct 26, 2021
| @@ -272,6 +273,13 @@ def create_scaling_policy(connection, module): | |||
| if module.params['cooldown']: | |||
| params['Cooldown'] = module.params['cooldown'] | |||
|
|
|||
| if policy_type == 'TargetTrackingScaling': | |||
There was a problem hiding this comment.
You can do this with a required_if in main when the module is instantiated. Like in these examples
https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/ecs_taskdefinition.py#L806-L809
https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/ecs_service.py#L695-L700
|
As it is now, |
falcon78921
force-pushed
the
aws-544-scaling
branch
from
90dff1d to
fc44cfe
Compare
falcon78921
force-pushed
the
aws-544-scaling
branch
from
fc44cfe to
59c600d
Compare
jillr
reviewed
Dec 10, 2021
falcon78921
force-pushed
the
aws-544-scaling
branch
from
d12f026 to
c843c19
Compare
|
Build failed.
|
|
Build failed.
|
jillr
reviewed
Jan 4, 2022
| module.fail_json(msg='step_adjustments is required when policy_type is StepScaling ' | ||
| 'and state is present') | ||
| module.fail_json(msg='step_adjustments is required when policy_type is StepScaling' | ||
| 'and state is present') |
There was a problem hiding this comment.
it looks like your editor has "format on save" enabled, this creates a lot of unnecessary diff noise which can be difficult to review (now, and if we need to go through git history later for bugfixes). would you be able to toggle this setting off for this repo and back out the formatting changes in this file please?
|
Build failed.
|
falcon78921
force-pushed
the
aws-544-scaling
branch
from
b5a7e23 to
eeb9022
Compare
ansibullbot
added
integration
|
Build failed (third-party-check pipeline) integration testing with
|
|
Build failed.
|
|
Build failed (third-party-check pipeline) integration testing with
|
|
ansible-test-units-community-aws-python38 fails here: I don't think this is related to |
|
Build failed.
|
|
Build failed (third-party-check pipeline) integration testing with
|
|
Build failed.
|
|
@jillr The sanity tests finally passed! :) When running the AWS integration tests in my environment, everything checks out ok. Not sure if I'm missing something. |
tremble
approved these changes
Jul 4, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
and removed
needs_rebase
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1306 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: #544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 4be1e70)
tremble
pushed a commit
that referenced
this pull request
Jul 4, 2022
add `TargetTrackingScaling` as a scaling policy option SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: #544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Jill R <None> Reviewed-by: James McClune <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 4be1e70)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
[PR #771/4be1e701 backport][stable-4] add `TargetTrackingScaling` as a scaling policy option This is a backport of PR #771 as merged into main (4be1e70). SUMMARY Add TargetTrackingScaling as an EC2 scaling option. Fixes: #544 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_scaling_policy.py Reviewed-by: Mark Chappell <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
TargetTrackingScalingas an EC2 scaling option.Fixes: #544
ISSUE TYPE
COMPONENT NAME
ec2_scaling_policy.py