Respect wait parameter in elb_instance when adding/removing instances #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
There was a problem hiding this comment.
@hughsaunders thank you for taking time to fix this bug. Could you also please add a changelog fragment for this fix?
The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: ansible-collections#825
hughsaunders
force-pushed
the
825_elb_instance_wait
branch
from
9f3a5ea to
1dfc9ca
Compare
|
Build succeeded.
|
|
@alinabuzachis thanks for the review, I've added a changelog snippet as requested. |
alinabuzachis
approved these changes
Jan 21, 2022
markuman
approved these changes
Jan 21, 2022
markuman
added
backport-2
|
@alinabuzachis @markuman, do either of you know whats up with the |
markuman
added
mergeit
|
Build succeeded (gate pipeline).
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #886 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
…#826) Respect wait parameter in elb_instance when adding/removing instances SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: #825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See #825 Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 99c64a6)
|
@hughsaunders thx for your notice us about the hanging process. And thx for your contribution! |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
…#826) (#886) [PR #826/99c64a6e backport][stable-2] Respect wait parameter in elb_instance when adding/removing instances This is a backport of PR #826 as merged into main (99c64a6). SUMMARY The wait parameter is currently ignored when registering or deregistering an instance with an ELB. Looks like this was lost in the boto3 migration: 96f1518 Related: #825 ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_instance ADDITIONAL INFORMATION See #825
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ollections#826) inventory aws_ec2 - allow for literal strings in hostnames SUMMARY Allow for literal strings in hostnames rather than throwing an AnsibleError Fixes ansible-collections#814 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Is there a better way of allowing for literal strings here? Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The wait parameter is currently ignored when registering or
deregistering an instance with an ELB. Looks like this was lost in the
boto3 migration: 96f1518
Related: #825
ISSUE TYPE
COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
See #825