Remove duplicate botocore requirement from aws_msk_config docs #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module doc has a botocore requirement line, and the aws doc fragment also has a requirement line. The collection requirement is higher than the module requirement so this is redundant.
|
Build failed.
|
alinabuzachis
approved these changes
Jan 11, 2022
|
recheck |
|
Build succeeded.
|
|
I don't think this is needed now as it's been superceded by https://github.com/ansible-collections/community.aws/pull/863/files |
|
Thanks @marknet15! |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ns#856) ec2_instance - Fix NoneType error on no input tags SUMMARY Reverts bug introduced in ansible-collections#849 which throws a NoneType exception when tags are not input ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION The error gets thrown when trying to wrap dict(None). See https://ansible.softwarefactory-project.io/zuul/build/5e37b5947f7045c6bf01e88f8ae5271f TASK [elb_classic_lb : Wait for instance a] ************************************ task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/elb_classic_lb/tasks/simple_instances.yml:18 Using module file /home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py Pipelining is enabled. <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python && sleep 0' The full traceback is: Traceback (most recent call last): File "<stdin>", line 121, in <module> File "<stdin>", line 113, in _ansiballz_main File "<stdin>", line 61, in invoke_module File "/usr/lib64/python3.8/runpy.py", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File "/usr/lib64/python3.8/runpy.py", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File "/usr/lib64/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py", line 2105, in <module> File "/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py", line 2097, in main File "/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py", line 1783, in handle_existing TypeError: 'NoneType' object is not iterable fatal: [testhost]: FAILED! => { "changed": false, "module_stderr": "Traceback (most recent call last):\n File \"<stdin>\", line 121, in <module>\n File \"<stdin>\", line 113, in _ansiballz_main\n File \"<stdin>\", line 61, in invoke_module\n File \"/usr/lib64/python3.8/runpy.py\", line 207, in run_module\n return _run_module_code(code, init_globals, run_name, mod_spec)\n File \"/usr/lib64/python3.8/runpy.py\", line 97, in _run_module_code\n _run_code(code, mod_globals, init_globals,\n File \"/usr/lib64/python3.8/runpy.py\", line 87, in _run_code\n exec(code, run_globals)\n File \"/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py\", line 2105, in <module>\n File \"/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py\", line 2097, in main\n File \"/tmp/ansible_ec2_instance_payload_ofa2yzhm/ansible_ec2_instance_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_instance.py\", line 1783, in handle_existing\nTypeError: 'NoneType' object is not iterable\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1 } Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
*_info - improve RETURN block of docs Depends-On: ansible-collections#856 SUMMARY Fixes ansible-collections#843 Can things like checking for a period after description be added to our sanity checks? ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ax_info aws_caller_info aws_s3 cloudformation_info ec2_eni_info ec2_group ec2_group_info ec2_instance_info ec2_key ec2_metadata_facts ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_tag ec2_tag_info ec2_vpc_dhcp_option_info ec2_vpc_endpoint_info ec2_vpc_endpoint_service_info ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ec2_vpc_net_info ec2_vpc_route_table_info elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Module doc has a botocore requirement line, and the aws doc fragment also has a requirement line. The collection requirement is higher than the module requirement so this is redundant.
ISSUE TYPE
COMPONENT NAME
aws_msk_config
This has been duplicated in the docs for some time so IMO we don't need to merge this before 3.0.0 releases; that way we don't have to regenerate the docs for the release. We can backport after the release.