Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Final removal of original boto SDK #898

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 28, 2022

SUMMARY
  • Remove old boto based inventory script
  • Clean up requirements
  • Clean up random comments in docs/comments
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt

ADDITIONAL INFORMATION

@tremble tremble changed the title [DNM] Final removal of original boto SDK [Breaking Change] Final removal of original boto SDK Jan 28, 2022
@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration inventory inventory plugin module module labels Jan 28, 2022
@tremble tremble added do_not_backport This PR should not be backported to stable- branches unless absolutely necessary and removed feature This issue/PR relates to a feature request integration tests/integration inventory inventory plugin module module community_review labels Jan 28, 2022
@ansibullbot ansibullbot added needs_triage plugins plugin (any type) tests tests labels Jan 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

@tremble tremble requested a review from jillr January 28, 2022 18:51
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 31, 2022
@softwarefactory-project-zuul

This comment has been minimized.

@tremble
Copy link
Contributor Author

tremble commented Jan 31, 2022

regate - Failed tests didn't start up

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 00037be into ansible-collections:main Jan 31, 2022
@tremble tremble deleted the boto/removal branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
[Breaking Change] Final removal of original boto SDK

SUMMARY

Remove old boto based inventory script
Clean up requirements
Clean up random comments in docs/comments

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@00037be
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
[Breaking Change] Final removal of original boto SDK

SUMMARY

Remove old boto based inventory script
Clean up requirements
Clean up random comments in docs/comments

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@00037be
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
[Breaking Change] Final removal of original boto SDK

SUMMARY

Remove old boto based inventory script
Clean up requirements
Clean up random comments in docs/comments

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@00037be
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
[Breaking Change] Final removal of original boto SDK

SUMMARY

Remove old boto based inventory script
Clean up requirements
Clean up random comments in docs/comments

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
scripts/inventory/ec2.py
requirements.txt
test-requirements.txt
tests/integration/requirements.txt
tests/unit/requirements.txt
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@00037be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants