Allow to configure PBKDF #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The luks_device tests now run in < 50 seconds (https://app.shippable.com/github/ansible-collections/community.crypto/runs/843/7/console), as opposed to ~3 minutes (see #152). |
|
@mulatinho if you have some time, please also take a look at this luks_device PR :-) |
felixfontein
force-pushed
the
luks-iterations
branch
from
a035bc3 to
6b76843
Compare
Open
|
@Andersson007 the main reason is that not every version of cryptsetup supports all of them. I found a way to make it still work though :) |
Co-authored-by: Andrew Klychkov <[email protected]>
Andersson007
approved these changes
Jan 22, 2021
|
@Andersson007 thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #152 (and implements some more).
ISSUE TYPE
COMPONENT NAME
luks_device