Fix update_failure_action KeyError in docker_swarm_service

[sgpinkus]

SUMMARY

I get this error in docker_swarm_service module with python docker 3.4.1 and docker 20:

    Traceback (most recent call last):
      File \"/home/admin/.ansible/tmp/ansible-tmp-1615509171.9495375-199788209305166/AnsiballZ_docker_swarm_service.py\", line 102, in <module>
        _ansiballz_main()
      File \"/home/admin/.ansible/tmp/ansible-tmp-1615509171.9495375-199788209305166/AnsiballZ_docker_swarm_service.py\", line 94, in _ansiballz_main
        invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
      File \"/home/admin/.ansible/tmp/ansible-tmp-1615509171.9495375-199788209305166/AnsiballZ_docker_swarm_service.py\", line 40, in invoke_module
        runpy.run_module(mod_name='ansible_collections.community.docker.plugins.modules.docker_swarm_service', init_globals=None, run_name='__main__', alter_sys=True)
      File \"/usr/lib/python2.7/runpy.py\", line 188, in run_module
        fname, loader, pkg_name)
      File \"/usr/lib/python2.7/runpy.py\", line 82, in _run_module_code
        mod_name, mod_fname, mod_loader, pkg_name)
      File \"/usr/lib/python2.7/runpy.py\", line 72, in _run_code
        exec code in run_globals
      File \"/tmp/ansible_community.docker.docker_swarm_service_payload__rn1HO/ansible_community.docker.docker_swarm_service_payload.zip/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py\", line 2833, in <module>
      File \"/tmp/ansible_community.docker.docker_swarm_service_payload__rn1HO/ansible_community.docker.docker_swarm_service_payload.zip/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py\", line 2807, in main
      File \"/tmp/ansible_community.docker.docker_swarm_service_payload__rn1HO/ansible_community.docker.docker_swarm_service_payload.zip/ansible_collections/community/docker/plugins/module_utils/common.py\", line 678, in __init__
      File \"/tmp/ansible_community.docker.docker_swarm_service_payload__rn1HO/ansible_community.docker.docker_swarm_service_payload.zip/ansible_collections/community/docker/plugins/module_utils/common.py\", line 709, in _get_minimal_versions
      File \"/tmp/ansible_community.docker.docker_swarm_service_payload__rn1HO/ansible_community.docker.docker_swarm_service_payload.zip/ansible_collections/community/docker/plugins/modules/docker_swarm_service.py\", line 2555, in _detect_update_config_failure_action_rollback
    KeyError: 'update_failure_action'

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

docker_swarm_service

ADDITIONAL INFORMATION

To reproduce the error in a playbook:

- hosts: swarm-master
  tasks:
    - name: add swarm service
      community.docker.docker_swarm_service:
        state: present
        name: my-test-service
        replicas: 1
        force_update: yes
        debug: yes
        image: nginx
        publish:
          - target_port: 8080
          - published_port: 8080
      register: result
    - debug: var=result

Where swarm-master is configure swarm master.

After change above exception goes away.

[felixfontein]

I'm pretty sure that this is the wrong fix. A module option of this name no longer exists. I suspect we forgot to remove this part when removing some deprecated options.

It's probably best to remove this line and change the next two to

     return rollback_config_failure_action == 'rollback'

CC @dariko @jwitko @hannseman @WojciechowskiPiotr

[felixfontein]

With the following suggestion and a changelog fragment, I think this would be ok.

[felixfontein]

@sgpinkus thanks a lot for fixing this!