Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_plugin: configure plugin after installing it #135

Merged
merged 1 commit into from
May 7, 2021
Merged

docker_plugin: configure plugin after installing it #135

merged 1 commit into from
May 7, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Hopefully fixes #118.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_plugin

@felixfontein felixfontein mentioned this pull request May 4, 2021
Closed
Andersson007
Andersson007 approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ grep -r plugin_options tests/integration/
tests/integration/targets/docker_plugin/tasks/tests/basic.yml:# Integration-Test with plugin_options is in TODO-List

heh
I think it's time we did it:)

If you test it locally and this change fixes the issue, LGTM

@felixfontein
Copy link
Collaborator Author

I can't test it locally since I don't use docker plugins. Unfortunately @pavlentio never reacted to my questions, so I don't know whether this actually works.

@Andersson007
Copy link
Collaborator

LGTM

@felixfontein felixfontein mentioned this pull request May 5, 2021
Open
@felixfontein felixfontein merged commit 3a0d3e1 into ansible-collections:main May 7, 2021
@felixfontein felixfontein deleted the fix-docker-plugin branch May 7, 2021 05:14
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_plugin driver options not configure plugin
2 participants
@felixfontein @Andersson007