Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_compose - Adding profiles option. #167

Merged
merged 3 commits into from
Jun 28, 2021
Merged

docker_compose - Adding profiles option. #167

merged 3 commits into from
Jun 28, 2021

Conversation

Ajpantuso
Copy link
Collaborator

SUMMARY

Adding profiles option to docker_compose.

Implements #116

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/docker_compose.py

ADDITIONAL INFORMATION
  • Simple addition by setting the option value when not None or []
  • Integration tests only run when compose >= 1.28.0 since that's when profiles was added.

@Ajpantuso Ajpantuso marked this pull request as ready for review June 27, 2021 19:42
felixfontein
felixfontein approved these changes Jun 27, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not very familiar with the docker_compose module, but in case nobody with more experience takes a look until tomorrow evening, I'll merge :)

@felixfontein felixfontein merged commit 072d96c into ansible-collections:main Jun 28, 2021
@felixfontein
Copy link
Collaborator

@Ajpantuso thanks for adding this option!

@Ajpantuso Ajpantuso deleted the docker_compose_profiles branch June 28, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ajpantuso @felixfontein