docker_compose - Fix startup errors for docker-compose versions <1.17.0 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajpantuso
changed the title
plugins/modules/docker_compose.py
Outdated
| @@ -146,6 +146,7 @@ | |||
| description: | |||
| - Use with I(state) C(present) to stop all containers defined in the Compose file. | |||
| - If I(services) is defined, only the containers listed there will be stopped. | |||
| - Requires C(docker-compose) version 1.17.0 or greater. | |||
There was a problem hiding this comment.
Suggested change
| - Requires C(docker-compose) version 1.17.0 or greater. | |
| - Requires C(docker-compose) version 1.17.0 or greater for full support. | |
| For older versions, the services will first be started and then stopped when | |
| the service is supposed to be created as stopped. |
felixfontein
approved these changes
Jul 28, 2021
|
@Ajpantuso thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes
docker_composefailures when starting services fordocker-compose <1.17.0Fixes #180
ISSUE TYPE
COMPONENT NAME
plugins/modules/docker_compose.py
ADDITIONAL INFORMATION
docker-compose ==1.16.0vsdocker-compose==1.29.0