Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when ansible_key label is not found on a secret. #31

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

kaysond
Copy link
Contributor

@kaysond kaysond commented Nov 8, 2020

See #30

@kaysond
Copy link
Contributor Author

kaysond commented Nov 8, 2020

Tested locally on

ansible 2.10.3
  config file = None
  configured module search path = ['/home/administrator/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.8/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.8.5 (default, Jul 28 2020, 12:59:40) [GCC 9.3.0]

Didn't add a unit test because its a trivial change, but happy to add one at request.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This needs a changelog fragment, though.

@kaysond kaysond changed the title Add a warning when ansible_label is not found on a secret. Add a warning when ansible_key label is not found on a secret. Nov 9, 2020
@kaysond
Copy link
Contributor Author

kaysond commented Nov 9, 2020

Added

@felixfontein felixfontein merged commit 22ba76b into ansible-collections:main Nov 9, 2020
@felixfontein
Copy link
Collaborator

@kaysond thanks for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants