[stable-1] docker connection plugin: fix config docs and update to use config system #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem (ansible-collections#297) * fix config docs and update to use config system wean off play_context which did not have the correct data in all cases * moar fixes * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * updated for backwards compat * badmergeresolution * makeitworks * attempt to fix unit test * mocking it# No more than 50 chars. #### 50 chars is here: # * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/connection/docker.py Co-authored-by: Felix Fontein <[email protected]> * nomock * remove bad paste * properly load connection to initialize config * initizlie docker args * Fix bugs. * Call _set_conn_data() when needed. * Cache result of _get_docker_remote_user() now that it is called multiple times per task. * Fix unit tests. * list.clear() is Python 3... * Add changelog. * Call _set_conn_data() also in _connect(). Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 37a3264)
briantist
approved these changes
Mar 21, 2022
briantist
approved these changes
Mar 23, 2022
|
@briantist thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #297 to stable-1. Removes all 2.2.0 additions from its commit.
ISSUE TYPE
COMPONENT NAME
docker connection plugin