docker.py: allow docker versions beginning with 'v'

[voondo]

I don't know why, but here, the docker version output begins with a 'v':

$ docker version --format "{{.Server.Version}}"
v20.10.1

which trigger this error:

Traceback (most recent call last):
  File "/home/romain/pro/aubonticket/.venv/lib/python3.8/site-packages/ansible/executor/task_executor.py", line 158, in run
    res = self._execute()
  File "/home/romain/pro/aubonticket/.venv/lib/python3.8/site-packages/ansible/executor/task_executor.py", line 613, in _execute
    self._connection = self._get_connection(cvars, templar)
  File "/home/romain/pro/aubonticket/.venv/lib/python3.8/site-packages/ansible/executor/task_executor.py", line 908, in _get_connection
    connection, plugin_load_context = self._shared_loader_obj.connection_loader.get_with_context(
  File "/home/romain/pro/aubonticket/.venv/lib/python3.8/site-packages/ansible/plugins/loader.py", line 826, in get_with_context
    obj.__init__(instance, *args, **kwargs)
  File "/home/romain/pro/aubonticket/.venv/lib/python3.8/site-packages/ansible_collections/community/general/plugins/connection/docker.py", line 93, in __init__
    if docker_version != u'dev' and LooseVersion(docker_version) < LooseVersion(u'1.3'):
  File "/usr/host/lib/python3.8/distutils/version.py", line 52, in __lt__
    c = self._cmp(other)
  File "/usr/host/lib/python3.8/distutils/version.py", line 337, in _cmp
    if self.version < other.version:
TypeError: '<' not supported between instances of 'str' and 'int'
fatal: [server]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
}

SUMMARY

I modified the _sanitize_version method to handle this case.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

plugins/connection/docker.py

[felixfontein]

That's an interesting finding! For me, that command gives the version without a leading v (20.10.0 and 20.10.2). I don't have 20.10.1 installed somewhere, maybe it just happens there?

In any case, could you please add a changelog fragment?

[voondo]

I added the changelog fragment as requested.

About this mysterious 'v', maybe is it caused by the fact that the dockerd packaged by my linux distribution is built from moby and is not the official prebuilt Docker CE ? I don't know

[felixfontein]

Out of curiosity, which distribution is it that you have this problem with? I've checked with both Arch Linux (I think the package is also built from moby: https://github.com/archlinux/svntogit-community/blob/packages/docker/trunk/PKGBUILD) and Debian (using the official docker-ce packages from https://download.docker.com/linux/debian).

[voondo]

It's exherbo where Docker itself is a set composed of theses packages:

• app-virtualization/docker-cli
• app-virtualization/moby
• sys-apps/containerd
• sys-apps/runc
• sys-apps/tini
• virtualization-lib/libnetwork

Honestly, I'm not an docker expert so I can't tell more...

[felixfontein]

@voondo thanks for this fix! I'll probably do a bugfix release of the collection this evening so this gets out ASAP.

I've never really looked at how Moby is built, so I can't tell either :) I just dwell through the sources sometimes to try to figure out how something works in the CLI to find out how to achieve the same result with the API resp. Docker SDK for Python... :)