Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix passwordstore.py to be compatible with gopass versions #1493

Merged
merged 3 commits into from
Jan 3, 2021
Merged

fix passwordstore.py to be compatible with gopass versions #1493

merged 3 commits into from
Jan 3, 2021

Conversation

yeoldegrove
Copy link
Contributor

SUMMARY

gopass show is deprecated and executing it will result in these messages:

gopass mypass
DEPRECATION WARNING: Use gopass show
mysecret

The DEPRECATION WARNING: Use gopass show will be written to a file looked up by passwordstore.py.

This commit fixes it by using pass show instead of pass.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

passwordstore.py

ADDITIONAL INFORMATION

@yeoldegrove
Be compatible to latest gopass versions.
3881960 
`gopass show` is deprecated.
@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review lookup lookup plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Dec 15, 2020
@felixfontein
Copy link
Collaborator

Thanks for the contribution!

  1. Does show work with every supported version of the tool, or is some logic necessary so it continues to work with all older versions as well?
  2. Every change needs a changelog fragment.

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407 label Dec 17, 2020
@yeoldegrove
Copy link
Contributor Author

yeoldegrove commented Dec 30, 2020 •
edited
Loading

  1. Does show work with every supported version of the tool, or is some logic necessary so it continues to work with all older versions as well?

AFAIK show has worked for a long time in pass. At least in the past years where I used it.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Dec 30, 2020
@yeoldegrove
Copy link
Contributor Author

yeoldegrove commented Dec 31, 2020 •
edited
Loading 

2\. Every change needs a [changelog fragment](https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to).

added the fragment as requested in 9f24d00

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Dec 31, 2020
@felixfontein felixfontein added backport-1 check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 31, 2020
@felixfontein felixfontein merged commit 491b622 into ansible-collections:main Jan 3, 2021
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 3, 2021
patchback bot pushed a commit that referenced this pull request Jan 3, 2021
@yeoldegrove
fix passwordstore.py to be compatible with gopass versions (#1493)
bf92723 
* Be compatible to latest gopass versions.
`gopass show` is deprecated.

* add changelog fragment

* Update changelogs/fragments/1493-fix_passwordstore.py_to_be_compatible_with_gopass_versions.yml

Co-authored-by: Eike Waldt <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 491b622)
@patchback patchback bot mentioned this pull request Jan 3, 2021
Merged
@felixfontein
Copy link
Collaborator

@yeoldegrove thanks for fixing this!

felixfontein pushed a commit that referenced this pull request Jan 3, 2021
@patchback @yeoldegrove
fix passwordstore.py to be compatible with gopass versions (#1493) (#…
b7a44a5 
…1580)

* Be compatible to latest gopass versions.
`gopass show` is deprecated.

* add changelog fragment

* Update changelogs/fragments/1493-fix_passwordstore.py_to_be_compatible_with_gopass_versions.yml

Co-authored-by: Eike Waldt <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 491b622)

Co-authored-by: Eike Waldt <[email protected]>
@felixfontein felixfontein mentioned this pull request Jun 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review lookup lookup plugin needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407 small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeoldegrove @felixfontein @gundalow @ansibullbot