Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add puppet confdir option #4740

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Add puppet confdir option #4740

merged 4 commits into from
Jun 6, 2022

Conversation

Ge0rgi0s
Copy link
Contributor

SUMMARY

Add the confdir option to the puppet plugin to configure a custom confdir location.
See puppet documentation

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

system puppet

@ansibullbot
Copy link
Collaborator

cc @emonty @nibalizer
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) system labels May 27, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels May 28, 2022
felixfontein
felixfontein reviewed May 28, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels May 28, 2022
@felixfontein
Copy link
Collaborator

Looks good to me. If the maintainers do not comment, I'll merge this for the 5.1.0 release.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 6, 2022
@felixfontein felixfontein merged commit 62ff263 into ansible-collections:main Jun 6, 2022
@patchback
Copy link

patchback bot commented Jun 6, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/62ff263ac1204a35a693e2f30e4bbe95cdb37c21/pr-4740

Backported as #4787

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 6, 2022
@Ge0rgi0s @patchback
Add puppet confdir option (#4740)
5d7dd03 
* Add puppet confdir option

* Add puppet confdir option change fragment

* Improve quoting in plugins/modules/system/puppet.py

Co-authored-by: Felix Fontein <[email protected]>

* Add version_added to plugins/modules/system/puppet.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Georg Vogt <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 62ff263)
@patchback patchback bot mentioned this pull request Jun 6, 2022
Merged
@felixfontein
Copy link
Collaborator

@Ge0rgi0s thanks for contributing this!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 6, 2022
felixfontein pushed a commit that referenced this pull request Jun 6, 2022
@patchback @Ge0rgi0s
Add puppet confdir option (#4740) (#4787)
8f0ee69 
* Add puppet confdir option

* Add puppet confdir option change fragment

* Improve quoting in plugins/modules/system/puppet.py

Co-authored-by: Felix Fontein <[email protected]>

* Add version_added to plugins/modules/system/puppet.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Georg Vogt <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 62ff263)

Co-authored-by: Ge0rgi0s <[email protected]>
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@lumiere-bot lumiere-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ergho-bot ergho-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@angelnu-bot angelnu-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ghost ghost mentioned this pull request Nov 7, 2022
Merged
1 task
@feisar-bot feisar-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@iudicael-bot iudicael-bot bot mentioned this pull request Nov 7, 2022
Closed
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ge0rgi0s @ansibullbot @felixfontein