Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to distinguish between different backends of the passwordstore lookup plugin #4779

Closed
wants to merge 2 commits into from
Closed

Add ability to distinguish between different backends of the passwordstore lookup plugin #4779

wants to merge 2 commits into from

Conversation

stephan-devop
Copy link

SUMMARY

The passwordstore lookup plugin was designed with pass as backend. gopass is a drop-in replacement which happens to have slightly different behaviour than pass. This change introduces a method setup_backend which populates self.backend with either the string pass (which is the default) or gopass if the string gopass is contained in the output of pass --version. Afterwards, the backends can be handled individually by the plugin.

Fixes #4766

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

passwordstore.py

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug lookup lookup plugin new_contributor Help guide this first time contributor plugins plugin (any type) labels Jun 4, 2022
@stephan-devop stephan-devop mentioned this pull request Jun 5, 2022
Closed
1 task
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Jun 5, 2022
@grembo grembo mentioned this pull request Jun 12, 2022
Merged
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 13, 2022
@patchback patchback bot mentioned this pull request Jun 15, 2022
Merged
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 15, 2022
@felixfontein
Copy link
Collaborator

felixfontein commented Jun 15, 2022 •
edited
Loading

Since #4780 has been merged this is likely no longer necessary. @stephan-devop if you agree, please close this PR. Thanks a lot for your work on it!

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 15, 2022
@stephan-devop
Copy link
Author

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_issue lookup lookup plugin needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

passwordstore lookup plugin gopass compatibility
3 participants
@stephan-devop @felixfontein @ansibullbot