bugfix for xfs_quota not properly initializing project quotas

[MichaelRiss]

SUMMARY

xfs_quota is not properly initializing xfs project quota groups (#5143), this PR proposes a fix.
Fixes #5143

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

xfs_quota

ADDITIONAL INFORMATION

This is an attempt to re-submit #3350. Hopefully this time all tests succeed.

[ansibullbot]

cc @bushvin
click here for bot help

[MichaelRiss]

It looks like the tests about idempotency fail. I looked at the code of the module and I haven't seen any code which tries to compare the current state of the target system with the intended state of the target system and then returns result["changed"] = False if the target system is already correctly configured. In this sense the failing tests would not be a regression as the bug is already there. Is there any way to trigger the same tests but with the current main branch?

[felixfontein]

Thanks for your contribution! I've added a first small comment on the changelog fragment.

[felixfontein]

Suggested change

	- xfs_quota - the call to "xfs_quota" to set up project quotas was missing the project name and hence failed (https://github.com/ansible-collections/community.general/issues/5143).
	- xfs_quota - the call to ``xfs_quota`` to set up project quotas was missing the project name and hence failed (https://github.com/ansible-collections/community.general/issues/5143).

[MichaelRiss]

Will do. Out of curiosity, why is one quotation mark style preferred over the other one? Do these fragments get parsed later with some script/tool which needs this kind of style?

[felixfontein]

The strings in these fragments are interpreted as reStructuredText; they end up in CHANGELOG.rst (for exmaple https://github.com/ansible-collections/community.general/blob/stable-5/CHANGELOG.rst).

[MichaelRiss]

Thanks for the explanation! I read about .rst files but never worked with them so far.

[felixfontein]

Is there any way to trigger the same tests but with the current main branch?

These tests run (and pass) every night. https://dev.azure.com/ansible/community.general/_build/results?buildId=51843&view=results is such a run.

[MichaelRiss]

I checked the past runs of test suite and they indeed succeed. I will need some time to understand how and why the tests succeed on the current main branch and why I have problems in my application with it.

[MichaelRiss]

Trying to replicate the test suite, but it seems the xfs_quota integration test cannot be run locally.

[felixfontein]

In CI the xfs_quota tests are restricted to VMs since you cannot mount a file in a container when the container isn't privileged, which they are not in CI for security reasons.

What you can do is run it locally with --docker-privileged (i.e. something like ansible-test integration --docker centos7 -v --docker-privileged xfs_quota), that might work.

[felixfontein]

Please note that in #5461 the collection repository was restructured to remove the directory tree in plugins/modules/, and the corresponding tree in tests/unit/plugins/modules/. Your PR modifies files in this directory structure, and unfortunately now has some conflicts, potentially because of this. Please rebase with the current main branch to remove the conflicts.

[russoz]

Hi @MichaelRiss, thanks for the contribution! LGTM, but it needs a rebase

[russoz]

By the way, instructions to rebasing: https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html

[felixfontein]

See also #6387.

[felixfontein]

needs_info

[ansibullbot]

@MichaelRiss This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibullbot]

@MichaelRiss You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help