Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #3889/dc2d3c24 backport][stable-4] Make pfexec become usable for illumos #5338

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[PR #3889/dc2d3c24 backport][stable-4] Make pfexec become usable for illumos #5338

merged 1 commit into from
Oct 5, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 5, 2022

This is a backport of PR #3889 as merged into main (dc2d3c2).

SUMMARY

Pfexec become does not work for illumos
fixes #3671

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/become/pfexec.py

ADDITIONAL INFORMATION

Changed quoting and command composition in analogy to standard su become

@manschwetusCF @patchback
Make pfexec become usable for illumos (#3889)
7fbd717 
* Experimental change from OpenIndiana

* resolve pfexec problem, by removing superfluous quotes

* reimplement "wrap_exe"

* remove spaces arround keyword argument assignment

* adapted pfexec unit test

* Try to fix quoting of test expression

* Fix quoting of test expression by replacing ' with "

* Add changelog fragment

(cherry picked from commit dc2d3c2)
@patchback patchback bot mentioned this pull request Oct 5, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @None
click here for bot help

@ansibullbot ansibullbot added backport become become plugin bug This issue/PR relates to a bug new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 5, 2022
@felixfontein felixfontein merged commit cb26897 into stable-4 Oct 5, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/dc2d3c24fa0e1e148c626b5cd0e3eff3231c2074/pr-3889 branch October 5, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
become become plugin bug This issue/PR relates to a bug needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @manschwetusCF