Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5367/dfe1f9a2 backport][stable-5] consul: pythonisms + a couple of required_if clauses #5380

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 18, 2022

This is a backport of PR #5367 as merged into main (dfe1f9a).

SUMMARY

Minor refactor on the module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/clustering/consul/consul.py

* consul: pythonisms + a couple of required_if clauses

* adjust condition of if

* adjust condition of if (again)

* Update plugins/modules/clustering/consul/consul.py

Co-authored-by: Felix Fontein <[email protected]>

* simplify parse_check logic

* fix condition of if

* remove test made redundant by required_if

* add changelog fragment

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit dfe1f9a)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug clustering module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 18, 2022
@felixfontein felixfontein merged commit d6cd908 into stable-5 Oct 18, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/dfe1f9a29eedd05648e77fcc4877194d069bca5a/pr-5367 branch October 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug clustering module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants