one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5489

d34d5p4rr0w · 2022-11-07T10:16:32Z

SUMMARY

Got a bug with NoneTypee when parsing VM's list, create small fix for this
'NoneType' object has no attribute 'split'

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

community.general.one_vm.py

ADDITIONAL INFORMATION

VM without labels and caused an exception in function
get_vm_labels_and_attributes_dict
AttributeError: 'NoneType' object has no attribute 'split'

File \"/tmp/ansible_community.general.one_vm_payload_ko5loyc4/ansible_community.general.one_vm_payload.zip/ansible_collections/community/general/plugins/modules/cloud/opennebula/one_vm.py\", line 993, in get_vm_labels_and_attributes_dict\nAttributeError: 'NoneType' object has no attribute 'split'\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

After fix everything is fine

ansibullbot · 2022-11-07T10:21:53Z

cc @ilicmilan @meerkampdvv @nilsding @rsmontero @xorel
click here for bot help

felixfontein

Thanks for your contribution! Can you please add a changelog fragment? Thanks!

d34d5p4rr0w · 2022-11-08T14:27:42Z

Thanks for your contribution! Can you please add a changelog fragment? Thanks!

Added changelog

changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml

Co-authored-by: Felix Fontein <[email protected]>

felixfontein · 2022-11-08T20:43:52Z

Can you fix the line endings in the changelog fragment (Windows style → Unix style)?

d34d5p4rr0w · 2022-11-08T20:47:21Z

Can you fix the line endings in the changelog fragment (Windows style → Unix style)?

Okay, made it

patchback · 2022-11-08T22:00:09Z

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/621fb6a619fce1d45a72dc2b46bdbc3fb64d86d5/pr-5489

Backported as #5512

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…labels_and_attributes_dict (#5489) * Fix for 'NoneType' object has no attribute 'split' * Added changelog to fix * Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Co-authored-by: Felix Fontein <[email protected]> * Fix line ending in changelog Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 621fb6a)

patchback · 2022-11-08T22:00:21Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/621fb6a619fce1d45a72dc2b46bdbc3fb64d86d5/pr-5489

Backported as #5513

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein · 2022-11-08T22:00:23Z

@d34d5p4rr0w thanks for fixing this!

…labels_and_attributes_dict (#5489) * Fix for 'NoneType' object has no attribute 'split' * Added changelog to fix * Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Co-authored-by: Felix Fontein <[email protected]> * Fix line ending in changelog Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 621fb6a)

…labels_and_attributes_dict (#5489) (#5513) * Fix for 'NoneType' object has no attribute 'split' * Added changelog to fix * Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Co-authored-by: Felix Fontein <[email protected]> * Fix line ending in changelog Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 621fb6a) Co-authored-by: wh1t3 r4bb1t <[email protected]>

…labels_and_attributes_dict (#5489) (#5512) * Fix for 'NoneType' object has no attribute 'split' * Added changelog to fix * Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Co-authored-by: Felix Fontein <[email protected]> * Fix line ending in changelog Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 621fb6a) Co-authored-by: wh1t3 r4bb1t <[email protected]>

…labels_and_attributes_dict (ansible-collections#5489) * Fix for 'NoneType' object has no attribute 'split' * Added changelog to fix * Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Co-authored-by: Felix Fontein <[email protected]> * Fix line ending in changelog Co-authored-by: Felix Fontein <[email protected]>

Fix for 'NoneType' object has no attribute 'split'

02e46b9

ansibullbot added bug This issue/PR relates to a bug cloud module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 7, 2022

felixfontein changed the title ~~Fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict~~ one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict Nov 7, 2022

felixfontein reviewed Nov 7, 2022

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Nov 7, 2022

Added changelog to fix

a65ff47

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed small_patch Hopefully easy to review labels Nov 8, 2022

felixfontein reviewed Nov 8, 2022

View reviewed changes

changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml Outdated Show resolved Hide resolved

felixfontein added the backport-6 label Nov 8, 2022

Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml

42b5e00

Co-authored-by: Felix Fontein <[email protected]>

Fix line ending in changelog

8916384

felixfontein approved these changes Nov 8, 2022

View reviewed changes

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 8, 2022

felixfontein merged commit 621fb6a into ansible-collections:main Nov 8, 2022

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 8, 2022

patchback bot mentioned this pull request Nov 8, 2022

[PR #5489/621fb6a6 backport][stable-5] one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5512

Merged

patchback bot mentioned this pull request Nov 8, 2022

[PR #5489/621fb6a6 backport][stable-6] one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5513

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5489

one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5489

d34d5p4rr0w commented Nov 7, 2022

ansibullbot commented Nov 7, 2022

felixfontein left a comment

d34d5p4rr0w commented Nov 8, 2022

This comment was marked as outdated.

felixfontein commented Nov 8, 2022

d34d5p4rr0w commented Nov 8, 2022 •

edited

Loading

patchback bot commented Nov 8, 2022 •

edited

Loading

patchback bot commented Nov 8, 2022 •

edited

Loading

felixfontein commented Nov 8, 2022

one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5489

one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict #5489

Conversation

d34d5p4rr0w commented Nov 7, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Nov 7, 2022

felixfontein left a comment

Choose a reason for hiding this comment

d34d5p4rr0w commented Nov 8, 2022

This comment was marked as outdated.

felixfontein commented Nov 8, 2022

d34d5p4rr0w commented Nov 8, 2022 • edited Loading

patchback bot commented Nov 8, 2022 • edited Loading

Backport to stable-5: 💚 backport PR created

patchback bot commented Nov 8, 2022 • edited Loading

Backport to stable-6: 💚 backport PR created

felixfontein commented Nov 8, 2022

d34d5p4rr0w commented Nov 8, 2022 •

edited

Loading

patchback bot commented Nov 8, 2022 •

edited

Loading

patchback bot commented Nov 8, 2022 •

edited

Loading