java_certs : Not enough info on error #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just bumped into an issue when the message was "Internal module failure, cannot extract public certificate from pkcs12, error: " Seems that the issue ansible-collections#2560 doesn't cover all cases. To make debugging easier, I propose to add error output on json return instead of only expose standard output.
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Can you please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
ansibullbot
removed
the
needs_revision
ansibullbot
added
needs_revision
changelogs/fragments/5550-java_certs-not-enough-info-on-error.yml
Outdated
Show resolved
Hide resolved
ansibullbot
removed
the
needs_revision
|
Other than the wordsmithing by Felix, LGTM |
felixfontein
approved these changes
Nov 28, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5623 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
* java_certs : Not enough info on error Just bumped into an issue when the message was "Internal module failure, cannot extract public certificate from pkcs12, error: " Seems that the issue #2560 doesn't cover all cases. To make debugging easier, I propose to add error output on json return instead of only expose standard output. * java_certs - add missing fragment message * Word-smithing. Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 1ca7752)
felixfontein
pushed a commit
that referenced
this pull request
Nov 29, 2022
* java_certs : Not enough info on error Just bumped into an issue when the message was "Internal module failure, cannot extract public certificate from pkcs12, error: " Seems that the issue #2560 doesn't cover all cases. To make debugging easier, I propose to add error output on json return instead of only expose standard output. * java_certs - add missing fragment message * Word-smithing. Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 1ca7752) Co-authored-by: Naewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Just bumped into an issue when the message was
"Internal module failure, cannot extract public certificate from pkcs12, error: "and found it not really helpfull.ISSUE TYPE
COMPONENT NAME
java_certs
ADDITIONAL INFORMATION
Seems that the issue #2560 doesn't cover all cases, so to make debugging easier, I propose to add error output on json return instead of only expose standard output.